From: Shuai Zhang <shuai.zhang@oss.qualcomm.com>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org, chejiang@qti.qualcomm.com,
quic_chezhou@quicinc.com, wei.deng@oss.qualcomm.com,
jinwang.li@oss.qualcomm.com, mengshi.wu@oss.qualcomm.com
Subject: Re: [PATCH v3 0/2] Bluetooth: hci_qca: Reopen port after power on for QCA2066
Date: Fri, 6 Nov 2026 14:35:25 +0800 [thread overview]
Message-ID: <561c0f8c-3252-4802-9d2c-ca1f93c65247@oss.qualcomm.com> (raw)
In-Reply-To: <ygy2hd47c3tb4vr2joiiy4bbg7rd4pn66x3co7iifv65cvnrf7@g36i65agh6p3>
Hi Bartosz
On 10/30/2026 5:29 PM, Bartosz Golaszewski wrote:
> On Wed, Oct 28, 2026 at 07:18:37PM +0800, Shuai Zhang wrote:
>> QCA2066 needs the serial port reopened after the controller is powered
>> on, otherwise the host and the controller run into RTS/CTS
>> synchronization issues.
>>
>> Patch 1 reopens the port in qca_power_on() for QCA2066, as in v2.
>>
>> Patch 2 keeps HCI_UART_PROTO_READY in sync with the port state, so that a
>> port which failed to reopen is not closed or flushed again.
>>
>> Changes in v3:
>> - Patch 1 is unchanged from v2.
>> - Add patch 2. If serdev_device_open() fails during the reopen, the
>> port stays closed but HCI_UART_PROTO_READY stays set, so the later
>> serdev_device_close() and hci_uart_flush() use a closed port. Keep
>> the flag in sync with the port state and skip the port flush when
>> the port is not open.
>> - Link to v2:
>> https://lore.kernel.org/all/20261016022302.4003647-1-shuai.zhang@oss.qualcomm.com/
>>
>> Changes in v2:
>> - Use a separate case for clearer logic.
>> - Link to v1:
>> https://lore.kernel.org/all/20261015092224.262158-1-shuai.zhang@oss.qualcomm.com/
>>
>> Shuai Zhang (2):
>> Bluetooth: hci_qca: Reopen port after power on for QCA2066
>> Bluetooth: hci_qca: Don't use the serdev port after a failed reopen
>>
>> drivers/bluetooth/hci_qca.c | 46 +++++++++++++++++++++++++++++-----
>> drivers/bluetooth/hci_serdev.c | 6 +++--
>> 2 files changed, 44 insertions(+), 8 deletions(-)
>>
>> --
>> 2.34.1
>>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Just want to confirm if there's anything else I need to do before
applying it.
Thanks,
Shuai
next prev parent reply other threads:[~2026-11-06 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 11:18 Shuai Zhang
2026-10-28 11:18 ` [PATCH v3 1/2] " Shuai Zhang
2026-10-28 11:18 ` [PATCH v3 2/2] Bluetooth: hci_qca: Don't use the serdev port after a failed reopen Shuai Zhang
2026-10-30 9:29 ` [PATCH v3 0/2] Bluetooth: hci_qca: Reopen port after power on for QCA2066 Bartosz Golaszewski
2026-11-06 6:35 ` Shuai Zhang [this message]
2026-11-06 9:17 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561c0f8c-3252-4802-9d2c-ca1f93c65247@oss.qualcomm.com \
--to=shuai.zhang@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=chejiang@qti.qualcomm.com \
--cc=jinwang.li@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mengshi.wu@oss.qualcomm.com \
--cc=quic_chezhou@quicinc.com \
--cc=wei.deng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®