mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Willy Tarreau <w@1wt.eu>
Cc: Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/nolibc: fix testcase status alignment
Date: Sun, 5 Nov 2023 15:39:15 +0100	[thread overview]
Message-ID: <56200e5a-b516-4ef8-9b0c-5b1dbbdd4ce9@t-8ch.de> (raw)
In-Reply-To: <20231105142659.GA21217@1wt.eu>

On 2023-11-05 15:27:00+0100, Willy Tarreau wrote:
> On Sun, Nov 05, 2023 at 03:22:30PM +0100, Thomas Weißschuh wrote:
> > Center-align all possible status reports.
> > Before OK and FAIL were center-aligned in relation to each other but
> > SKIPPED and FAILED would be left-aligned.
> > 
> > Before:
> > 
> > 7 environ_addr = <0x7fffef3e7c50>                                [OK]
> > 8 environ_envp = <0x7fffef3e7c58>                               [FAIL]
> > 9 environ_auxv                                                  [SKIPPED]
> > 10 environ_total                                                [SKIPPED]
> > 11 environ_HOME = <0x7fffef3e99bd>                               [OK]
> > 12 auxv_addr                                                    [SKIPPED]
> > 13 auxv_AT_UID = 1000                                            [OK]
> > 
> > After:
> > 
> > 7 environ_addr = <0x7ffff13b00a0>                                 [OK]
> > 8 environ_envp = <0x7ffff13b00a8>                                [FAIL]
> > 9 environ_auxv                                                  [SKIPPED]
> > 10 environ_total                                                [SKIPPED]
> > 11 environ_HOME = <0x7ffff13b19bd>                                [OK]
> > 12 auxv_addr                                                    [SKIPPED]
> > 13 auxv_AT_UID = 1000                                             [OK]
> > 
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> 
> Quite frankly for trivial cleanups like this you should not even bother
> with sending a review, and could queue them directly!

Ok, will do!


Thomas

      reply	other threads:[~2023-11-05 14:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-05 14:22 Thomas Weißschuh
2023-11-05 14:27 ` Willy Tarreau
2023-11-05 14:39   ` Thomas Weißschuh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56200e5a-b516-4ef8-9b0c-5b1dbbdd4ce9@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®