From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669AbbJPLrA (ORCPT ); Fri, 16 Oct 2015 07:47:00 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:51225 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbbJPLq5 (ORCPT ); Fri, 16 Oct 2015 07:46:57 -0400 X-AuditID: cbfee68d-f79ae6d00000149a-b6-5620e3af95fe Message-id: <5620E17B.9080906@samsung.com> Date: Fri, 16 Oct 2015 17:07:31 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Kukjin Kim , Douglas Anderson , Tomeu Vizoso , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach References: <1444927873-15140-1-git-send-email-javier@osg.samsung.com> In-reply-to: <1444927873-15140-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsWyRsSkWnf9Y4Uwgx9TNCzOLjvIZvHm7Rom i9cvDC36H79mttj0+BqrxeVdc9gsZpzfx2TRt/YSmwOHx+yGiyweO+4uYfTYtKqTzWPzknqP Lf132T36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoEr4/uBS4wFxyQr3n04zdrAeFyki5GTQ0LA ROL3n3fsELaYxIV769m6GLk4hARWMErsebyVsYuRA6zo3bcaiPgsRoneGV0sEM4DRokJKzeB dfMKaEm8/9XIDGKzCKhK9H3+wAJiswloS9ydvoUJZJCoQITE4wtCEOWCEj8m3wMrEREIlfh3 8TYjyExmgS+MErunH2cFSQgLpEocO3eSCcQWEnCT2HL5Kth8TgF3ie+3m8DizALWEisnbWOE sOUlNq95ywwySELgLbvEhadT2CAOEpD4NvkQC8Q3shKbDjBDfCwpcXDFDZYJjGKzkNw0C8nY WUjGLmBkXsUomlqQXFCclF5kqFecmFtcmpeul5yfu4kRGJGn/z3r3cF4+4D1IUYBDkYlHl4G O4UwIdbEsuLK3EOMpkBXTGSWEk3OB8Z9Xkm8obGZkYWpiamxkbmlmZI4r6LUz2AhgfTEktTs 1NSC1KL4otKc1OJDjEwcnFINjLuCn3fyFxwNnvPTadaDfYmt/aFbd+hwxd97WM7Hv6fP5Hc7 89n8W6z/fX0mNpjXvTx15tDajVFXSh2PPTz9QV2149P5H4yLpQ+H6tWoHSqYN2/H03ulqlHd Qs+3NX5+wTRZJOKN7YL1H5e+nbApQqq91Tdvl1uY7fu/fCty3qdnMr57tvdKQ6MSS3FGoqEW c1FxIgBucgnBwwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLIsWRmVeSWpSXmKPExsVy+t9jQd31jxXCDB48UbA4u+wgm8Wbt2uY LF6/MLTof/ya2WLT42usFpd3zWGzmHF+H5NF39pLbA4cHrMbLrJ47Li7hNFj06pONo/NS+o9 tvTfZffo27KK0ePzJrkA9qgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8 xNxUWyUXnwBdt8wcoKOUFMoSc0qBQgGJxcVK+naYJoSGuOlawDRG6PqGBMH1GBmggYQ1jBnf D1xiLDgmWfHuw2nWBsbjIl2MHBwSAiYS777VdDFyApliEhfurWfrYuTiEBKYxSjRO6OLBcJ5 wCgxYeUmdpAqXgEtife/GplBbBYBVYm+zx9YQGw2AW2Ju9O3MIEMFRWIkHh8QQiiXFDix+R7 YCUiAqES/y7eZgSZySzwhVFi9/TjrCAJYYFUiWPnTjKB2EICbhJbLl8Fm88p4C7x/XYTWJxZ wFpi5aRtjBC2vMTmNW+ZJzACnYmwYxaSsllIyhYwMq9ilEgtSC4oTkrPNcxLLdcrTswtLs1L 10vOz93ECI76Z1I7GA/ucj/EKMDBqMTDy2CnECbEmlhWXJl7iFGCg1lJhNdmP1CINyWxsiq1 KD++qDQntfgQoykwECYyS4km5wMTUl5JvKGxibmpsamliYWJmaWSOO+NQwxhQgLpiSWp2amp BalFMH1MHJxSDYy9/Y+LJVwebVwwvS3n6cpTc9/mhdyrvXclZ9q/+7YZBxiqpGRXXT3DNcui 4q3GRunpC+LvRB3r7jsafNDa9of308L3e7+em83osnrX5AvnijJae+uuFf0oafuj2Pzw6cT5 v1VvBnB9W6O/+cRlA80wN79HT6VuvZB+1RvlKvTFbWX+AxXf5rxcJZbijERDLeai4kQAeVzn UhADAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: > Hello, > > The Exynos Chromebooks DTS don't use the correct card detection properties > since these were carried from the vendor tree that had a reason to do so. > > There are two things that I noticed: > > 1) The Marvell WiFi SDIO is marked as broken-cd instead of non-removable: > > This causes the device to be removed when the system enters into a suspend > state which leads to the following warning when the system is resumed: > > [ 181.944636] mmc2: error -2 during resume (card was removed?) > > The rationale for using broken-cd is explained in downstream commit [0] and > was that using the non-removable property caused issues with the mwifiex > driver since the reset logic called the mmc_{remove,add}_host() functions. > > But the reset logic in the mwifiex mainline driver has changed and this is > no longer the case so it's safe to use the non-removable property AFAICT. > Good to know it is fixed now. This is fixed in firmware or in the driver? > 2) The eMMC node has both broken-cd and non-removable but the MMC DT binding > doc (Documentation/devicetree/bindings/mmc/mmc.txt) mentions that only one > of these card detection properties should be used. > This change looks ok, will take a closer look once I am back to my work station. > So this series change both the SDIO WiFi and eMMC device nodes in the Snow, > Peach Pi and Peach Pit boards DTS to use the non-removable property. > > To test, I've cherry picked commit [1] from the vendor tree that adds a > debugfs entry to force a card reset and after the reset, the WiFi card still > works correctly: > > $ echo 1 > /sys/kernel/debug/mwifiex/mlan0/reset > > And also tested that both eMMC and WiFi are working correctly after a S2R. > > The test were made on an Exynos5800 Peach Pi but I don't have access to a > Snow anymore so testing patch 3/6 and 6/6 on that board will be appreciated. > > v1 of the series was [2] and this version fixes issues pointed out by Tomeu. > > Changes since v1: > - Replace broken-cd for non-removable in the correct mmc node for Snow. > - Correct the card detetion properties for eMMC in Snow, Pit and Pi. > - Also remove the card-detect-delay property when using non-removable. > > [0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ad348e1e2381 > [1]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5995363523de > [2]: https://lkml.org/lkml/2015/10/15/294 > > Best regards, > Javier > > > Javier Martinez Canillas (6): > ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi > ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit > ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common > ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi > ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi > ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 6 ++---- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +---- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +---- > 3 files changed, 4 insertions(+), 12 deletions(-) >