From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: David Daney <ddaney.cavm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Len Brown <lenb@kernel.org>,
Tomasz Nowicki <tomasz.nowicki@linaro.org>,
Robert Richter <rrichter@cavium.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] acpi, property: Export acpi_dev_prop_read_single call.
Date: Wed, 05 Aug 2015 15:48:17 +0200 [thread overview]
Message-ID: <5621301.c1YGTkGNQk@vostro.rjw.lan> (raw)
In-Reply-To: <1438729319-9146-1-git-send-email-ddaney.cavm@gmail.com>
On Tuesday, August 04, 2015 04:01:59 PM David Daney wrote:
> From: Tomasz Nowicki <tomasz.nowicki@linaro.org>
>
> Fixes the following build error when building drivers as modules:
>
> ERROR: "acpi_dev_prop_read_single" [drivers/net/phy/mdio-octeon.ko] undefined!
> ERROR: "acpi_dev_prop_read_single" [drivers/net/ethernet/cavium/thunder/thunder_bgx.ko] undefined!
Can you please tell me why the drivers in question use that function
directly, although they aren't supposed to?
Clearly, their authors had not tried to build them as modules or they
would have noticed the problem at the development stage already.
What would be wrong with using the generic device properties API instead?
> Reported-by: Andreas Schwab <schwab@suse.de>
> Signed-off-by: Tomasz Nowicki <tomasz.nowicki@linaro.org>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> drivers/acpi/property.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index 7836e2e..237e3c5 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -432,6 +432,7 @@ int acpi_dev_prop_read_single(struct acpi_device *adev, const char *propname,
> }
> return ret;
> }
> +EXPORT_SYMBOL_GPL(acpi_dev_prop_read_single);
>
> static int acpi_copy_property_array_u8(const union acpi_object *items, u8 *val,
> size_t nval)
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-08-05 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 23:01 David Daney
2015-08-05 13:48 ` Rafael J. Wysocki [this message]
2015-08-05 13:43 ` Tomasz Nowicki
2015-08-05 17:26 ` David Daney
2015-08-05 20:14 ` David Daney
2015-08-05 23:23 ` Rafael J. Wysocki
2015-08-05 23:17 ` David Daney
2015-08-05 23:55 ` Rafael J. Wysocki
2015-08-05 23:49 ` David Daney
2015-08-05 23:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5621301.c1YGTkGNQk@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrichter@cavium.com \
--cc=tomasz.nowicki@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®