From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752633AbbJQMAt (ORCPT ); Sat, 17 Oct 2015 08:00:49 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:34569 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbbJQMAr (ORCPT ); Sat, 17 Oct 2015 08:00:47 -0400 Subject: Re: [PATCH] libata: add support for NCQ commands for SG interface To: vinayak.kale@gmail.com, tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <1445082519-8160-1-git-send-email-vinayak.kale@seagate.com> Cc: sumit.g.gupta@seagate.com, Vinayak Kale From: Sergei Shtylyov Message-ID: <5622386C.2000905@cogentembedded.com> Date: Sat, 17 Oct 2015 15:00:44 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445082519-8160-1-git-send-email-vinayak.kale@seagate.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10/17/2015 2:48 PM, vinayak.kale@gmail.com wrote: > From: Vinayak Kale > > This patch is needed to make NCQ commands with FPDMA protocol value > (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface. > > Signed-off-by: Vinayak Kale > --- > drivers/ata/libata-scsi.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c > index 0d7f0da..5b0a5ab 100644 > --- a/drivers/ata/libata-scsi.c > +++ b/drivers/ata/libata-scsi.c [...] > @@ -2963,7 +2965,7 @@ static unsigned int ata_scsi_pass_thru(struct ata_queued_cmd *qc) > tf->hob_lbal = cdb[7]; > tf->hob_lbam = cdb[9]; > tf->hob_lbah = cdb[11]; > - tf->flags |= ATA_TFLAG_LBA48; > + tf->flags |= (ATA_TFLAG_LBA48 | ATA_TFLAG_LBA); Parens not needed here. [...] MBR, Sergei