From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752605AbbJSALA (ORCPT ); Sun, 18 Oct 2015 20:11:00 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:28358 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752485AbbJSAKd (ORCPT ); Sun, 18 Oct 2015 20:10:33 -0400 X-AuditID: cbfec7f5-f794b6d000001495-e2-562434f5b4e0 Subject: Re: [PATCH v2 1/6] ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1444927873-15140-1-git-send-email-javier@osg.samsung.com> <1444927873-15140-2-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , Douglas Anderson , Alim Akhtar , Tomeu Vizoso , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <562434EF.4010604@samsung.com> Date: Mon, 19 Oct 2015 09:10:23 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1444927873-15140-2-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsVy+t/xa7pfTVTCDO79MbJ4MG8bm8XZZQfZ LN68XcNk8fqFoUX/49fMFpseX2O1uLxrDpvFjPP7mCz61l5ic+D0mN1wkcVjx90ljB6bVnWy eWxeUu+xpf8uu0ffllWMHp83yQWwR3HZpKTmZJalFunbJXBlnN+5k61gM3vFko1TGBsY/7B2 MXJySAiYSLxedIsRwhaTuHBvPVsXIxeHkMBSRokbDa9ZQBJCAl8YJZr2RHYxcnAIC0RKrJov BBIWEQiV+HfxNiNEfTOjxJW/D8AcZoE3jBLr3i5iB6liEzCW2Lx8CRvEBjmJ3u5JYEN5BbQk Tv26DhZnEVCVOH/tNNgVogIREhMnNLBC1AhK/Jh8D6yeU8BdYuKHmcwgRzAL6Encv6gFEmYW kJfYvOYt8wRGwVlIOmYhVM1CUrWAkXkVo2hqaXJBcVJ6rpFecWJucWleul5yfu4mRkh8fN3B uPSY1SFGAQ5GJR7eB0eUwoRYE8uKK3MPMUpwMCuJ8GYfVg4T4k1JrKxKLcqPLyrNSS0+xCjN waIkzjtz1/sQIYH0xJLU7NTUgtQimCwTB6dUA+MBkT1tFWttut9bvmL9WSTy7qNyodj1BKsd blPMLu3bXPev6LlJ7ets45eqPxz9WZ1D3eN3LNtzLo8/7Of/I9M4epjmPo84+8Dz40UWAXnV xWWT0/a6f4hRfbl+Vsez3NfMBt4JXz/yTJkXVjyH+fn1qa1bO9c73ZTven9c1r/51/HOr3Nc 07OVWIozEg21mIuKEwGFVCDjiwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.10.2015 01:51, Javier Martinez Canillas wrote: > The Exynos5800 Peach Pi Chromebook has a Marvell WiFi SDIO chip which > can't neither be removed nor be detected. But the node isn't marked > as non-removable and instead has the broken-cd DT property. > > This causes the device to be removed when the system enters into a > suspend state and the following warnings is shown after a resume: > > [ 181.944636] mmc2: error -2 during resume (card was removed?) > > Also remove the card-detect-delay property that is not needed with > non-removable. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes since v1: > - Remove card-detect-delay property as well. > > arch/arm/boot/dts/exynos5800-peach-pi.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) That sounds reasonable: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof