From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689AbbJSALM (ORCPT ); Sun, 18 Oct 2015 20:11:12 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:31192 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752499AbbJSALH (ORCPT ); Sun, 18 Oct 2015 20:11:07 -0400 X-AuditID: cbfec7f5-f794b6d000001495-09-562435185f99 Subject: Re: [RFT PATCH v2 3/6] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1444927873-15140-1-git-send-email-javier@osg.samsung.com> <1444927873-15140-4-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , Douglas Anderson , Alim Akhtar , Tomeu Vizoso , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56243512.9030706@samsung.com> Date: Mon, 19 Oct 2015 09:10:58 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1444927873-15140-4-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xq7oSpiphBs9f8Fo8mLeNzeLssoNs Fm/ermGyeP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TBZ9ay+xOXB6zG64yOKx4+4SRo9NqzrZ PDYvqffY0n+X3aNvyypGj8+b5ALYo7hsUlJzMstSi/TtErgyjn4XLLjMXvHn2inmBsbJbF2M nBwSAiYSW86eZoewxSQu3FsPFOfiEBJYyihx99lDKOcLo8TOr/OZQaqEBRIk5j25DNYtIhAq 8e/ibUYQW0igmVHiwf1SkAZmgTeMEuveLgIbyyZgLLF5+RKwBl4BLYl3XxrBBrEIqEpcXvcA rFlUIEJi4oQGVogaQYkfk++xgNicAu4Sm/e+AarnABqqJ3H/ohZImFlAXmLzmrfMExgFZiHp mIVQNQtJ1QJG5lWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsYIXHwdQfj0mNWhxgFOBiVeHgf HFEKE2JNLCuuzD3EKMHBrCTCm31YOUyINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNIT S1KzU1MLUotgskwcnFINjJdDpHs+b+VWeTvpcmvCCeFrs/UP77Iryz7SsM2na53NjxsfhZQS NYSjpovNTZ2zeOKHKqPGX6Ks4XslLhusD+y9IXP081WmWKkTPOonhIsFVH16S7ezGMksKTN8 mnb15mmD6MvSaqf253HKJNZdmLi/Q4JJ7U3eve4I+Q7Tul6ui4X2Wl+/KbEUZyQaajEXFScC AP44/iV/AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.10.2015 01:51, Javier Martinez Canillas wrote: > The Exynos5250 Snow Chromebooks have a Marvell WiFi SDIO chip which > can't neither be removed nor be detected. But the node isn't marked > as non-removable and instead has the broken-cd DT property. > > This causes the device to be removed when the system enters into a > suspend state and the following warnings is shown after a resume: > > [ 181.944636] mmc2: error -2 during resume (card was removed?) > > Also remove the card-detect-delay property that is not needed with > non-removable. > > Signed-off-by: Javier Martinez Canillas > --- > > Changes since v1: > - Remove card-detect-delay property as well. > - Use the correct mmc node. Suggested by Tomeu. > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof