From: Tianyu Lan <ltykernel@gmail.com>
To: Dexuan Cui <decui@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"hch@infradead.org" <hch@infradead.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
vkuznets <vkuznets@redhat.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"hch@lst.de" <hch@lst.de>,
"parri.andrea@gmail.com" <parri.andrea@gmail.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"andi.kleen@intel.com" <andi.kleen@intel.com>,
"kirill.shutemov" <kirill.shutemov@intel.com>
Subject: Re: [RFC PATCH V3 2/2] net: netvsc: Allocate per-device swiotlb bounce buffer for netvsc
Date: Fri, 27 May 2022 20:20:50 +0800 [thread overview]
Message-ID: <56243d2b-d7f6-9e45-d5fd-3af7767d52e3@gmail.com> (raw)
In-Reply-To: <BYAPR21MB12706372826A3ABAEF42E716BFD99@BYAPR21MB1270.namprd21.prod.outlook.com>
On 5/27/2022 2:43 AM, Dexuan Cui wrote:
>> From: Tianyu Lan <ltykernel@gmail.com>
>> Sent: Thursday, May 26, 2022 5:01 AM
>> ...
>> @@ -119,6 +124,10 @@ static void netvsc_subchan_work(struct work_struct
>> *w)
>> nvdev->max_chn = 1;
>> nvdev->num_chn = 1;
>> }
>> +
>> + /* Allocate boucne buffer.*/
>> + swiotlb_device_allocate(&hdev->device, nvdev->num_chn,
>> + 10 * IO_TLB_BLOCK_UNIT);
>> }
>
> Looks like swiotlb_device_allocate() is not called if the netvsc device
> has only 1 primary channel and no sub-schannel, e.g. in the case of
> single-vCPU VM?
When there is only sinlge,there seems not to be much performance
penalty. But you are right, we should keep the same behavior when single
CPU and multi CPU. Will update in the next version.
Thanks.
prev parent reply other threads:[~2022-05-27 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 12:01 [RFC PATCH V3 0/2] swiotlb: Add child io tlb mem support Tianyu Lan
2022-05-26 12:01 ` [RFC PATCH V3 1/2] swiotlb: Add Child IO TLB " Tianyu Lan
2022-05-26 12:01 ` [RFC PATCH V3 2/2] net: netvsc: Allocate per-device swiotlb bounce buffer for netvsc Tianyu Lan
[not found] ` <BYAPR21MB12706372826A3ABAEF42E716BFD99@BYAPR21MB1270.namprd21.prod.outlook.com>
2022-05-27 12:20 ` Tianyu Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56243d2b-d7f6-9e45-d5fd-3af7767d52e3@gmail.com \
--to=ltykernel@gmail.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=andi.kleen@intel.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=kirill.shutemov@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parri.andrea@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sthemmin@microsoft.com \
--cc=thomas.lendacky@amd.com \
--cc=tiala@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®