From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752682AbbJSBla (ORCPT <rfc822;w@1wt.eu>);
	Sun, 18 Oct 2015 21:41:30 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:19630 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752033AbbJSBl1 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 18 Oct 2015 21:41:27 -0400
X-AuditID: cbfec7f5-f794b6d000001495-16-56244a44a31d
Subject: Re: [PATCH] hwrng: exynos - Fix unbalanced PM runtime get/puts
To: Daniel Thompson <daniel.thompson@linaro.org>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Matt Mackall <mpm@selenic.com>
References: <1445011311-32142-1-git-send-email-daniel.thompson@linaro.org>
Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@linaro.org, linaro-kernel@lists.linaro.org,
        Kukjin Kim <kgene@kernel.org>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
X-Enigmail-Draft-Status: N1110
Message-id: <56244A38.4040207@samsung.com>
Date: Mon, 19 Oct 2015 10:41:12 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <1445011311-32142-1-git-send-email-daniel.thompson@linaro.org>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42I5/e/4VV0XL5Uwg97lohZn3txlt+h+JWPx
	+oWhRf/j18wW7w89Y7bY9Pgaq8X9ez+ZLC7vmsNmMeP8PiaLBdv6GC2mHP7C4sDtse2Aqsem
	VZ1sHneu7WHz2Lyk3uP2v8fMHn1bVjF69L3cwOjxeZNcAEcUl01Kak5mWWqRvl0CV8a9K6eY
	C5ZzVDRP6GJrYLzF1sXIySEhYCLRePgWI4QtJnHh3nqgOBeHkMBSRokZ/64wQjhfGCVuH3vN
	ClIlLOAuMbX7MxOILSJQIzHp0HswW0jAS+Lq3aksIA3MAg8YJa4/2gbWwCZgLLF5+RKodXIS
	vd2TWEBsXgEtib71m8GaWQRUJf4umggWFxWIkJg4oYEVokZQ4sfke2BxTgFviUUHnzN3MXIA
	LdCTuH9RCyTMLCAvsXnNW+YJjIKzkHTMQqiahaRqASPzKkbR1NLkguKk9FwjveLE3OLSvHS9
	5PzcTYyQ2Pm6g3HpMatDjAIcjEo8vA+OKIUJsSaWFVfmHmKU4GBWEuHNPqwcJsSbklhZlVqU
	H19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQZG+aLC487FL7dvCIrpW8ly
	J/bQ2q8+bd7tX953fd/55EOxYLN2an+60Yr3Ho+u8d5Qtzx7ZcLaCXM1XIRXFRxLaC/xL+k9
	PJvdo/SNw+6bPgtvLmCTTD7V+/siY//91U+2fruxl7eZtWHyDlc1d77GlXGXWHU+XJ9yNJQj
	6T9Pxf534naqBZlZSizFGYmGWsxFxYkAiS+jU5kCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 17.10.2015 01:01, Daniel Thompson wrote:
> Currently this driver calls pm_runtime_get_sync() rampantly
> but never puts anything back. This makes it impossible for the
> device to autosuspend properly; it will remain fully active
> after the first use.
> 
> Fix in the obvious way.
> 
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> 
> Notes:
>     Compile tested only (CONFIG_PM=y, CONFIG_HW_RANDOM_EXYNOS=m); I spotted
>     this whilst reviewing the code and don't have an exynos platform to
>     test on.
> 
>  drivers/char/hw_random/exynos-rng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

To test the patch I had to add OF support to the driver. I have these
patches almost ready and I will send them soon. Anyway:

Tested on Trats2 board (Exynos4412):
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof