From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbbJSDN4 (ORCPT ); Sun, 18 Oct 2015 23:13:56 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:45172 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbbJSDNx (ORCPT ); Sun, 18 Oct 2015 23:13:53 -0400 X-AuditID: cbfee68d-f79ae6d00000149a-0b-56245fdaa89e Message-id: <56245DB8.7070106@samsung.com> Date: Mon, 19 Oct 2015 08:34:24 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Kukjin Kim , Douglas Anderson , Tomeu Vizoso , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach References: <1444927873-15140-1-git-send-email-javier@osg.samsung.com> In-reply-to: <1444927873-15140-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsWyRsSkRvd2vEqYwft+Nouzyw6yWbx5u4bJ 4vULQ4v+x6+ZLTY9vsZqcXnXHDaLGef3MVn0rb3E5sDhMbvhIovHjrtLGD02repk89i8pN5j S/9ddo++LasYPT5vkgtgj+KySUnNySxLLdK3S+DK6JrZz1ZwT7LixISD7A2ML0S6GDk5JARM JDZ072WGsMUkLtxbz9bFyMUhJLCCUWLd2QesMEVPjpxkhEgsZZR4uPsalPOAUeLzqd9MIFW8 AloS768vBrNZBFQlutuWgtlsAtoSd6dvAbI5OEQFIiQeXxCCKBeU+DH5HguILSIQKvHv4m2w mcwCXxgldk8/DrZZWCBV4ti5k2BzhATcJLZcvgp2KqeAu8T3201gcWYBa4mVk7YxQtjyEpvX vIV65yW7xKEuZ4h7BCS+TT7EAnKDhICsxKYDUCWSEgdX3GCZwCg2C8lJs5BMnYVk6gJG5lWM oqkFyQXFSelFhnrFibnFpXnpesn5uZsYgRF5+t+z3h2Mtw9YH2IU4GBU4uF9cEQpTIg1say4 MvcQoynQFROZpUST84Fxn1cSb2hsZmRhamJqbGRuaaYkzqso9TNYSCA9sSQ1OzW1ILUovqg0 J7X4ECMTB6dUA6MB75aTwTHR/3uf8DvIeSxZIfqrI3O7Ogv3648O9hVn56Sk/gljMG7018w/ kePXFnTYL+Wc488/3XcnXRNgPHcyObpla9CEDY2Kk7jvW9dW1629FiE2afLbOWJb2CpWfmNa kMgs/lFzZs8rPsG6z0v3zEw8dKX2jFa/2uftbe0Xlx4O6LpdGKHEUpyRaKjFXFScCAD57Lox wwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsVy+t9jAd1b8SphBksbLSzOLjvIZvHm7Rom i9cvDC36H79mttj0+BqrxeVdc9gsZpzfx2TRt/YSmwOHx+yGiyweO+4uYfTYtKqTzWPzknqP Lf132T36tqxi9Pi8SS6APaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEv MTfVVsnFJ0DXLTMH6CglhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY0bX zH62gnuSFScmHGRvYHwh0sXIySEhYCLx5MhJRghbTOLCvfVsXYxcHEICSxklHu6+xgjhPGCU +HzqNxNIFa+AlsT764vBbBYBVYnutqVgNpuAtsTd6VuAbA4OUYEIiccXhCDKBSV+TL7HAmKL CIRK/Lt4G2wms8AXRond04+zgiSEBVIljp07CTZHSMBNYsvlq8wgNqeAu8T3201gcWYBa4mV k7YxQtjyEpvXvGWewCgwC8mOWUjKZiEpW8DIvIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/ dxMjOO6fSe1gPLjL/RCjAAejEg/vydvKYUKsiWXFlbmHGCU4mJVEeLMPA4V4UxIrq1KL8uOL SnNSiw8xmgIDYSKzlGhyPjAl5ZXEGxqbmJsam1qaWJiYWSqJ8944xBAmJJCeWJKanZpakFoE 08fEwSnVwCi1QvjIhr1JJV/DP7f3fv35O8T71pdXrAfNJmWs+Fdd+trvT2Wpp+4PDcbFxsUL E19/ivQtERFs0rveumezddh2N9YHcesUW9+u+vtLMjTp/+98MUf+NtGJjvpH2lVezZ8rsvUd w/GI95ZbBP6b1N8pnyP777jYgpdRX69UPLFhc47fYv+dZaYSS3FGoqEWc1FxIgCSYe7GEQMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: > Hello, > > The Exynos Chromebooks DTS don't use the correct card detection properties > since these were carried from the vendor tree that had a reason to do so. > > There are two things that I noticed: > > 1) The Marvell WiFi SDIO is marked as broken-cd instead of non-removable: > > This causes the device to be removed when the system enters into a suspend > state which leads to the following warning when the system is resumed: > > [ 181.944636] mmc2: error -2 during resume (card was removed?) > > The rationale for using broken-cd is explained in downstream commit [0] and > was that using the non-removable property caused issues with the mwifiex > driver since the reset logic called the mmc_{remove,add}_host() functions. > > But the reset logic in the mwifiex mainline driver has changed and this is > no longer the case so it's safe to use the non-removable property AFAICT. > > 2) The eMMC node has both broken-cd and non-removable but the MMC DT binding > doc (Documentation/devicetree/bindings/mmc/mmc.txt) mentions that only one > of these card detection properties should be used. > > So this series change both the SDIO WiFi and eMMC device nodes in the Snow, > Peach Pi and Peach Pit boards DTS to use the non-removable property. > > To test, I've cherry picked commit [1] from the vendor tree that adds a > debugfs entry to force a card reset and after the reset, the WiFi card still > works correctly: > > $ echo 1 > /sys/kernel/debug/mwifiex/mlan0/reset > > And also tested that both eMMC and WiFi are working correctly after a S2R. > > The test were made on an Exynos5800 Peach Pi but I don't have access to a > Snow anymore so testing patch 3/6 and 6/6 on that board will be appreciated. > > v1 of the series was [2] and this version fixes issues pointed out by Tomeu. > > Changes since v1: > - Replace broken-cd for non-removable in the correct mmc node for Snow. > - Correct the card detetion properties for eMMC in Snow, Pit and Pi. > - Also remove the card-detect-delay property when using non-removable. > > [0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ad348e1e2381 > [1]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5995363523de > [2]: https://lkml.org/lkml/2015/10/15/294 > > Best regards, > Javier > > > Javier Martinez Canillas (6): > ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi > ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit > ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common > ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi > ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi > ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common > This series looks good to me, so feel free to add Reviewed-by: Alim Akhtar and for patch 4 and 5: Tested-by: Alim Akhtar Thanks. > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 6 ++---- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +---- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +---- > 3 files changed, 4 insertions(+), 12 deletions(-) >