mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH 2/2] perf test: Suppress libtraceevent warnings
Date: Mon, 19 Oct 2015 10:09:26 -0600	[thread overview]
Message-ID: <562515B6.3050904@gmail.com> (raw)
In-Reply-To: <1445268229-1601-2-git-send-email-namhyung@kernel.org>

On 10/19/15 9:23 AM, Namhyung Kim wrote:
> Currently libtraceevent emits warning on unsupported event formats.
> However it'd be better to see them only -v option is given.  To do that,
> it needs to override the warning() function which is used in the
> libtracevent.  Thus add set_warning_routine() same as set_die_routine()
> and check the verbose flag in our warning routine.
>
> Before:
>    # perf test 5
>     5: parse events tests                                       :
>      Warning: [kvmmmu:kvm_mmu_get_page] bad op token {
>      Warning: [kvmmmu:kvm_mmu_sync_page] bad op token {
>      Warning: [kvmmmu:kvm_mmu_unsync_page] bad op token {
>      Warning: [kvmmmu:kvm_mmu_prepare_zap_page] bad op token {
>      Warning: [kvmmmu:fast_page_fault] function is_writable_pte not defined
>      ...
>     Ok
>
> After:
>    # perf test 5
>     5: parse events tests                                       : Ok
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
>   tools/perf/tests/parse-events.c | 14 ++++++++++++++
>   tools/perf/util/usage.c         |  5 +++++
>   tools/perf/util/util.h          |  1 +
>   3 files changed, 20 insertions(+)
>

Acked-by: David Ahern <dsahern@gmail.com>



  reply	other threads:[~2015-10-19 16:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 15:23 [PATCH 1/2] perf test: Silence tracepoint event failures Namhyung Kim
2015-10-19 15:23 ` [PATCH 2/2] perf test: Suppress libtraceevent warnings Namhyung Kim
2015-10-19 16:09   ` David Ahern [this message]
2015-10-19 18:00     ` Arnaldo Carvalho de Melo
2015-10-20  7:42   ` [tip:perf/core] " tip-bot for Namhyung Kim
2015-10-19 16:08 ` [PATCH 1/2] perf test: Silence tracepoint event failures David Ahern
2015-10-19 17:57 ` Arnaldo Carvalho de Melo
2015-10-20  7:42 ` [tip:perf/core] " tip-bot for Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562515B6.3050904@gmail.com \
    --to=dsahern@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome