From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753507AbbJSTF0 (ORCPT ); Mon, 19 Oct 2015 15:05:26 -0400 Received: from mout.gmx.net ([212.227.15.18]:63571 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbbJSTFY (ORCPT ); Mon, 19 Oct 2015 15:05:24 -0400 Subject: Re: [PATCH] adc: correctly check return value To: Insu Yun , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu References: <1445270931-24109-1-git-send-email-wuninsu@gmail.com> From: Hartmut Knaack Message-ID: <56253EE7.5050107@gmx.de> Date: Mon, 19 Oct 2015 21:05:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 MIME-Version: 1.0 In-Reply-To: <1445270931-24109-1-git-send-email-wuninsu@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:uZf2j5+JLkixbSMMo3RKo+T5B2XEogiHuMeMDrbyVLkuq4HC1xI sCIl/pzL/nciUbA2Z0mBSBgYBhkY8o0D5luLLr3wogcc7inmUS47yABwiJueWdLb93E2UCS d4Ni2s2hIJwAlzZpvhsR1um2lgRaEe5H9LsuUz+3Lr8ZTiQxNSreiToaaCekAoAvmnidoMg GlBRRb4Vp9iy+YIcLPURQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:sGwUcZbKwos=:Ju7ViUCSH9vMph8xybPOst NbJ19QnNiPwGk/RrHeHwt+yrk6vBw2tsWkOseaEq+H6n2WKGFfKCEm5ATdxVxS5tYm9L/UupO rDeZxOMvTYW/JiNqsrbqv4WoM3iC6Db8h+CRO8Sy9c/x0DDpsyLsXO/LMA9oSuS0qJ1GVdSwl tkjLZTvjOT9GMEg81tO5HsrsuN7lBVbBGx8Emuk1GyTs9u8lRnc4Vk9Lro1YUj2lbfIX6HlVV 9S+0E8eV9R/uBANRupmGer//EiJrb+2r4dd0M6b4dvM6ftoC0h5ivKWF1Q7U1KofVrBOHhR80 nhKSCoLCTksyBgx/DCVFu0eDrclhUri8JeWi4CxSPGdxQepU4Pf7JUTuih436m6z+9+AbSr26 zgGtdqdZ/bDuR+6blMx+CmHhytTalcKtHf7q4VWl6STfAJz0uUKsAK5PY2hy3zxnTHObNPKMH BcOHJLQaj4B1FyVwwGVG4FkBygJBsgiODSQFHxsElK42Tb9nQqosrW7erguM2QJBbgAoOqnfO HIlcbf2yBjK/Ey/GikPiOU7SGo2OoBxfjtY3ptIWiX302degsXilEeD4ilC0jya4/z9PpHetT EJcYpepdTz/hghaEvPuYmhvyCYca55wFC3S3wYDgprSc6NPpH/+HYCDLoCA7+AcBRu3kMctc6 KUVucbMUxdW5bRubeU5S6ZLdXK9Fg+EaPhomrz4+WFhvQJjI+W2QXJcJViRhkmhwyxZYbS0i0 iOwxZcw98mh87y4daJOirjW6XUxC32Aq94Xia6kpMLMP98GnywVcCVpz+kmRnfw02LwQ7BLbV CuZk+/H Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Insu Yun schrieb am 19.10.2015 um 18:08: > Since devm_regulator_get returns address or error, not NULL, > it needs to be checked with IS_ERR, not IS_ERR_OR_NULL. > Actually, it does return NULL, if regulator support is disabled (see [1]). [1]http://lxr.free-electrons.com/source/include/linux/regulator/consumer.h#L286 > Signed-off-by: Insu Yun > --- > drivers/iio/adc/ad7266.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c > index 70f78c3..26cd54b 100644 > --- a/drivers/iio/adc/ad7266.c > +++ b/drivers/iio/adc/ad7266.c > @@ -397,7 +397,7 @@ static int ad7266_probe(struct spi_device *spi) > st = iio_priv(indio_dev); > > st->reg = devm_regulator_get(&spi->dev, "vref"); > - if (!IS_ERR_OR_NULL(st->reg)) { > + if (!IS_ERR(st->reg)) { > ret = regulator_enable(st->reg); > if (ret) > return ret; >