From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbbJSX4e (ORCPT ); Mon, 19 Oct 2015 19:56:34 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:23209 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbbJSX4c (ORCPT ); Mon, 19 Oct 2015 19:56:32 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-68-5625832de9a5 Subject: Re: [PATCH v2] HID: hiddev: change hiddev_connect() to return bool To: Luis de Bethencourt References: <1444395633-12672-1-git-send-email-luisbg@osg.samsung.com> <5625083C.4000207@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, jikos@kernel.org, linux-usb@vger.kernel.org, linux-input@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5625832B.9010908@samsung.com> Date: Tue, 20 Oct 2015 08:56:27 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <5625083C.4000207@osg.samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xK7q6zaphBpd+KVrcOt7KaPH6haHF zU/fWC0u75rDZrFoWSuzxdF50xgd2Dw2repk89jSf5fdo2/LKkaPz5vkAliiuGxSUnMyy1KL 9O0SuDKmbmpnLjjNWfF00162BsbL7F2MnBwSAiYSq282MkHYYhIX7q1n62Lk4hASWMooMWPy DiYI5wujxK37F8A6hAW8JRr/zmAFsUUEDCQ+rT4IVbSJUeJqZw8jSIJZIEei5+oXsAY2AWOJ zcuXsIHYvAJaElsnrQSLswioSvQcOAsWFxWIkJg4oYEVokZQ4sfkeywgNqeAvsS7hg9ACziA ZqpLTJmSCzFeXmLzmrfMExgFZiHpmIVQNQtJ1QJG5lWMoqmlyQXFSem5hnrFibnFpXnpesn5 uZsYIeH8ZQfj4mNWhxgFOBiVeHg1YlTDhFgTy4orcw8xSnAwK4nwvq4HCvGmJFZWpRblxxeV 5qQWH2KU5mBREuedu+t9iJBAemJJanZqakFqEUyWiYNTqoHRo0fT7/9f/27fzUeOKRkliOxW 5bm278UeE8O32dPWBrRMXSpYvNLTW6wuvZcj/ZrLUZslhcm6K+S470i+82biD1Kq+1vgk6PZ 9GTayUs2cy+v9ohj6NsUOCFljVRc0LH3K5bbS9bPk/vhc8UrMHiu+rOL+12qG+5+TH2T+dRj 7vpnWfWPOrqUWIozEg21mIuKEwHCdYV1YwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.10.2015 00:11, Luis de Bethencourt wrote: > On 13/10/15 02:49, Krzysztof Kozlowski wrote: >> 2015-10-09 22:00 GMT+09:00 Luis de Bethencourt : >>> Since hid_connect() only cares about hiddev_connect() succeeding or >>> failing, there is no need for this function to return an int and it can >>> return a bool instead. >> >> It can return bool but it would not be in line with kernel coding >> style. The hiddev_connect() I believe is an action, so "the function >> should return an error-code integer.". >> >> Best regards, >> Krzysztof >> > > > Hi Krysztof, > > The idea to switch the function to return bool was offered by Jiri Kosina, > as a result of my initial patch changing the return errno code to ENOMEM. I did not see the original comment from Jiri. Actually changing it to ENOMEM makes more sense to me... > > Considering the return isn't propagated by the only consumer of the function, > and your point about returning an integer being the kernel coding style. It > doesn't make sense to change this function. Jiri is the maintainer here but for me sticking to coding convention (return errno) makes it easier to read. Best regards, Krzysztof