From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbbJTDrE (ORCPT ); Mon, 19 Oct 2015 23:47:04 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:53262 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbbJTDrB (ORCPT ); Mon, 19 Oct 2015 23:47:01 -0400 X-AuditID: cbfee691-f79d66d000001509-f7-5625b9287546 Message-id: <5625B92C.10505@samsung.com> Date: Tue, 20 Oct 2015 09:16:52 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene.kim@samsung.com, p.fedin@samsung.com, thomas.ab@samsung.com Subject: Re: [PATCH v4 6/8] drivers: soc: add support for exynos SROM driver References: <1445255206-11148-1-git-send-email-pankaj.dubey@samsung.com> <1445255206-11148-7-git-send-email-pankaj.dubey@samsung.com> <56258683.7070204@samsung.com> In-reply-to: <56258683.7070204@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWyRsSkVldjp2qYwe/dVhavXxha9C64ymax 6fE1VovLu+awWcw4v4/J4tWlVWwWHcsYHdg9Ni+p9+jbsorR4/MmuQDmKC6blNSczLLUIn27 BK6My6/msBTMk6pYcXYbawNjv2gXIyeHhICJxMJNzWwQtpjEhXvrgWwuDiGBFYwSnQt/MsEU vZ43gx0isZRRYtOHDmaQhJDAd0aJpv4KEJtXQEPi7IWfrCA2i4CqxMvPv8GmsgnoSjx5Pxes XlQgQuLt5ZNMEPWCEj8m32MBGSoiMIdRomv6ArAEs4CrxPZnbWANwgI+EmfXfGCBO2ltRzfY Bk4BbYkXk6axQzTYSix4v44FwpaX2LzmLTNIg4TAPnaJg3PfsUOcJCDxbfIhoCIOoISsxKYD zBCvSUocXHGDZQKj2CwkR81CMnYWkrELGJlXMYqmFiQXFCelF5nqFSfmFpfmpesl5+duYgRG 2Ol/zybuYLx/wPoQowAHoxIPr0aMapgQa2JZcWXuIUZToCsmMkuJJucD4zivJN7Q2MzIwtTE 1NjI3NJMSZxXR/pnsJBAemJJanZqakFqUXxRaU5q8SFGJg5OqQbGAyfcMr8vXnVzIe+CNOY/ pvfTn34KSCqYePMN+70PavFKt16w73h2w+vk0T1LglyFn6+8M5fzLZ+M7lzLbcFLUvVZrWfl 6QZFvp6r4zK/ja+OK0TAqs3b63qwoav+gXqO80+q6t41zI+/PvX99JSke+eK1Tnux4UKXXx9 tz0+0Ei15u6q09WaSizFGYmGWsxFxYkADYlG0KsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsVy+t9jAV2NnaphBl8uGFu8fmFo0bvgKpvF psfXWC0u75rDZjHj/D4mi1eXVrFZdCxjdGD32Lyk3qNvyypGj8+b5AKYoxoYbTJSE1NSixRS 85LzUzLz0m2VvIPjneNNzQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOAVisplCXmlAKFAhKLi5X0 7TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYMy6/msNSME+qYsXZbawNjP2iXYycHBICJhKv581g h7DFJC7cW8/WxcjFISSwlFFi04cOZpCEkMB3Romm/goQm1dAQ+LshZ+sIDaLgKrEy8+/2UBs NgFdiSfv54LViwpESLy9fJIJol5Q4sfkeywgQ0UE5jBKdE1fAJZgFnCV2P6sDaxBWMBH4uya DywQm1cwSqzt6AbbwCmgLfFi0jR2iAZbiQXv17FA2PISm9e8ZZ7AKDALyZJZSMpmISlbwMi8 ilEitSC5oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM4ip9J7WA8uMv9EKMAB6MSD69GjGqYEGti WXFl7iFGCQ5mJRFejR6gEG9KYmVValF+fFFpTmrxIUZTYDBMZJYSTc4HJpi8knhDYxNzU2NT SxMLEzNLJXHeG4cYwoQE0hNLUrNTUwtSi2D6mDg4pRoYxWIuqXXy2ibw7TAt2N4d3eL5t33h xc/SQbueHGFbmXSKVfrNur3xR/0+751frjJxqtWKr45Kx19afLj77hP3dfmtc9f9ztzRk7Dl J9M5l2fWmhbyzyNllWNNZJbYxTt4+QcFBD3amyNxKn7yO+fjf/bUhk2NeGIS0Jwo++v0h/8y hm6Jax/9V2Ipzkg01GIuKk4EABGEkhT4AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Tuesday 20 October 2015 05:40 AM, Krzysztof Kozlowski wrote: > On 19.10.2015 20:46, Pankaj Dubey wrote: >> This patch adds Exynos SROM controller driver which will handle >> save restore of SROM registers during S2R. >> >> Signed-off-by: Pankaj Dubey >> --- >> drivers/soc/Kconfig | 1 + >> drivers/soc/Makefile | 1 + >> drivers/soc/samsung/Kconfig | 13 +++ >> drivers/soc/samsung/Makefile | 1 + >> drivers/soc/samsung/exynos-srom.c | 179 ++++++++++++++++++++++++++++++++++++++ >> drivers/soc/samsung/exynos-srom.h | 51 +++++++++++ >> 6 files changed, 246 insertions(+) >> create mode 100644 drivers/soc/samsung/Kconfig >> create mode 100644 drivers/soc/samsung/Makefile >> create mode 100644 drivers/soc/samsung/exynos-srom.c >> create mode 100644 drivers/soc/samsung/exynos-srom.h >> >> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig >> index 96ddecb..69107c9 100644 >> --- a/drivers/soc/Kconfig >> +++ b/drivers/soc/Kconfig >> @@ -2,6 +2,7 @@ menu "SOC (System On Chip) specific Drivers" >> >> source "drivers/soc/mediatek/Kconfig" >> source "drivers/soc/qcom/Kconfig" >> +source "drivers/soc/samsung/Kconfig" >> source "drivers/soc/sunxi/Kconfig" >> source "drivers/soc/ti/Kconfig" >> source "drivers/soc/versatile/Kconfig" >> diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile >> index 0b12d77..a623616 100644 >> --- a/drivers/soc/Makefile >> +++ b/drivers/soc/Makefile >> @@ -5,6 +5,7 @@ >> obj-$(CONFIG_MACH_DOVE) += dove/ >> obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/ >> obj-$(CONFIG_ARCH_QCOM) += qcom/ >> +obj-$(CONFIG_SOC_SAMSUNG) += samsung/ >> obj-$(CONFIG_ARCH_SUNXI) += sunxi/ >> obj-$(CONFIG_ARCH_TEGRA) += tegra/ >> obj-$(CONFIG_SOC_TI) += ti/ >> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig >> new file mode 100644 >> index 0000000..ea4bc2a >> --- /dev/null >> +++ b/drivers/soc/samsung/Kconfig >> @@ -0,0 +1,13 @@ >> +# >> +# SAMSUNG SoC drivers >> +# >> +menu "Samsung SOC driver support" >> + >> +config SOC_SAMSUNG >> + bool >> + >> +config EXYNOS_SROM >> + bool >> + depends on ARM && ARCH_EXYNOS > > When !PM then the driver will... do nothing, right? So maybe make it > depending on PM so tiny configs would benefit? > Yes. Currently driver will do nothing if !PM. But as we know Fedin, has a plan to extend this driver for auxiliary H/W IP hooked to SROM. So in that case this dependency will not be valid as those functionality may not be dependent on PM, and we may need to remove it later. So I feel better not to add it at first place itself. >> +static int exynos_srom_remove(struct platform_device *pdev) >> +{ >> + struct exynos_srom *srom = platform_get_drvdata(pdev); >> + >> + kfree(srom->reg_offset); >> + iounmap(srom->reg_base); >> + srom->reg_base = NULL; >> + srom->reg_offset = NULL; > > There is no need anymore for these two NULL-s. It made sense only in > previous code when these were global variables. At this point the device > callbacks cannot be accessed so NULL-ifying does not change anything. > Agreed. Will update. > Rest from my point of view looks good. > Thanks for review. Pankaj > Best regards, > Krzysztof > >