From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752485AbbJTGsc (ORCPT ); Tue, 20 Oct 2015 02:48:32 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:29981 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbbJTGsa (ORCPT ); Tue, 20 Oct 2015 02:48:30 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-f6-5625e3bcb1c0 Subject: Re: [PATCH v4 6/8] drivers: soc: add support for exynos SROM driver To: Pavel Fedin , "'Pankaj Dubey'" , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1445255206-11148-1-git-send-email-pankaj.dubey@samsung.com> <1445255206-11148-7-git-send-email-pankaj.dubey@samsung.com> <56258683.7070204@samsung.com> <5625B92C.10505@samsung.com> <5625C07D.4030706@samsung.com> <014301d10b01$488873f0$d9995bd0$@samsung.com> Cc: kgene.kim@samsung.com, thomas.ab@samsung.com From: Krzysztof Kozlowski Message-id: <5625E3B9.8040707@samsung.com> Date: Tue, 20 Oct 2015 15:48:25 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <014301d10b01$488873f0$d9995bd0$@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t/xa7p7HquGGbx4ym/x+oWhRe+Cq2wW mx5fY7W4vGsOm8WM8/uYLF5dWsVmsWjrF3aLjmWMDhwem5fUe/RtWcXo8XmTXABzFJdNSmpO Zllqkb5dAlfGo2OHmQqmsFe82X2KpYHxMmsXIyeHhICJROPMi1C2mMSFe+vZuhi5OIQEljJK /Js2kxHC+cIocefFDyaQKmEBH4mzaz6wgCREBHYzShxeswKqagqTxJO+J2CzmAUMJH7cbADr YBMwlti8fAkbiM0roCWxbPc/MJtFQFXiyNk+MFtUIEJi4oQGVogaQYkfk++xgNicAlYSSx8u BqrhAJqpJ3H/ohbEeHmJzWveMk9gFJiFpGMWQtUsJFULGJlXMYqmliYXFCel5xrqFSfmFpfm pesl5+duYoSE9ZcdjIuPWR1iFOBgVOLh1YhRDRNiTSwrrsw9xCjBwawkwvvsBFCINyWxsiq1 KD++qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotgskwcnFINjJ43QrOK57d1n/HgiJjR 1fe4o6l/aWq3xwT/udmKHw1eWnYc1E7Z+Pf6L92iLvme3GlrUv6v2XmJSfGKsaFqWUuO3SqP sscfHtk6l3wMu2RWM+dFvb1M3DfRHy68V55Ven7SSbeaPmHmic83uzhy79tOb66rjNzs/zZ1 /Y6HSt23u8+k/7vLpcRSnJFoqMVcVJwIAOQ2neFnAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.10.2015 15:33, Pavel Fedin wrote: > Hello! > >> AFAIR Fedin was talking about missing functionality, not about adding >> the contribution by himself. So he might add it or he might not. I did >> not receive any commitments from him. > > I am waiting for the driver to be integrated, because i see it's constantly redesigned. Then i'll post my patches. That means you will extend the driver? Great! So from my point of view it is fine. Dear Pankaj, With the fix of unneeded NULL assignments: Reviewed-by: Krzysztof Kozlowski > By the way, they > will be useful only if pin controller driver for 5410 is accepted upstream, several authors have done it but i still didn't see it > in upstream. > Pin controller is needed in order to configure multi-functional pins correctly. Are there any obstacles for upstreaming it? Best regards, Krzysztof