mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: chenfeng <puck.chen@hisilicon.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <mark.rutland@arm.com>, <dan.zhao@hisilicon.com>,
	<linuxarm@huawei.com>, <joro@8bytes.org>,
	<z.liuxinliang@hisilicon.com>, <qijiwen@hisilicon.com>,
	<devicetree@vger.kernel.org>, <weidong2@hisilicon.com>,
	<pawel.moll@arm.com>, <ijc+devicetree@hellion.org.uk>,
	<suzhuangluan@hisilicon.com>, <robh+dt@kernel.org>,
	<puck.chen@aliyun.com>, <yudongbin@hisilicon.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<peter.panshilin@hisilicon.com>, <linux-kernel@vger.kernel.org>,
	<saberlily.xia@hisilicon.com>, <galak@codeaurora.org>
Subject: Re: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC
Date: Tue, 20 Oct 2015 18:17:13 +0800	[thread overview]
Message-ID: <562614A9.8050501@hisilicon.com> (raw)
In-Reply-To: <39316856.jTQkIxu0yn@wuerfel>


Thanks for review.
On 2015/10/20 17:00, Arnd Bergmann wrote:
> On Tuesday 20 October 2015 16:45:24 Chen Feng wrote:
>> +
>> +               smmu@f4210000 {
> 
> I think the canonical name for an IOMMU device is 'iommu', not 'smmu'.
Accept.
> 
>> +                       compatible = "hisilicon,hi6220-smmu";
>> +                       reg = <0x0 0xf4210000 0x0 0x1000>;
>> +                       interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
>> +                       clocks = <&sys_ctrl HI6220_MMU_CLK>,
>> +                                <&media_ctrl HI6220_MED_MMU>,
>> +                                <&sys_ctrl HI6220_MEDIA_PLL_SRC>;
>> +                       clock-names = "smmu_clk",
>> +                                     "media_sc_clk",
>> +                                     "smmu_peri_clk";
> 
> 
> Better avoid underscores in strings, and drop the "_clk" postfix in
> the clock names.
> 
> I did not receive patch 1/3 this time, but I see in version 1, that
> you forgot to document the strings:
> 
Accept, I will change this.
>> +- clock-names: The name to enable clock with clock framework.
> 
> This needs to list the names of the clock inputs to the smmu.
> 
> 	Arnd
> _______________________________________________
> linuxarm mailing list
> linuxarm@huawei.com
> http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm
> 
> .
> 


  reply	other threads:[~2015-10-20 10:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20  8:45 [PATCH V2 1/3] Documentation for system mmu in hi6220 platform Chen Feng
2015-10-20  8:45 ` [PATCH V2 2/3] Add iommu driver for hi6220 SoC platform Chen Feng
2015-10-20 15:02   ` Robin Murphy
2015-10-21  1:56     ` chenfeng
2015-10-23  9:10     ` chenfeng
2015-10-20  8:45 ` [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC Chen Feng
2015-10-20  9:00   ` Arnd Bergmann
2015-10-20 10:17     ` chenfeng [this message]
2015-10-20 10:34 ` [PATCH V2 1/3] Documentation for system mmu in hi6220 platform Mark Rutland
2015-10-20 12:33   ` chenfeng
2015-10-22  1:15 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562614A9.8050501@hisilicon.com \
    --to=puck.chen@hisilicon.com \
    --cc=arnd@arndb.de \
    --cc=dan.zhao@hisilicon.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=peter.panshilin@hisilicon.com \
    --cc=puck.chen@aliyun.com \
    --cc=qijiwen@hisilicon.com \
    --cc=robh+dt@kernel.org \
    --cc=saberlily.xia@hisilicon.com \
    --cc=suzhuangluan@hisilicon.com \
    --cc=weidong2@hisilicon.com \
    --cc=yudongbin@hisilicon.com \
    --cc=z.liuxinliang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome