From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299AbbJUBlV (ORCPT ); Tue, 20 Oct 2015 21:41:21 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:36289 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbbJUBlR (ORCPT ); Tue, 20 Oct 2015 21:41:17 -0400 Subject: Re: [PATCH 2/4] thermal: rockchip: ensure the otp state before resetting the controller To: Doug Anderson References: <1445332264-6054-1-git-send-email-wxt@rock-chips.com> <1445332264-6054-3-git-send-email-wxt@rock-chips.com> Cc: Caesar Wang , Heiko Stuebner , "linux-pm@vger.kernel.org" , Linus Walleij , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Eduardo Valentin , "open list:ARM/Rockchip SoC..." , Zhang Rui , "linux-arm-kernel@lists.infradead.org" From: Caesar Wang Message-ID: <5626ED35.3010403@gmail.com> Date: Wed, 21 Oct 2015 09:41:09 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug, 在 2015年10月20日 23:52, Doug Anderson 写道: > Caesar, > > On Tue, Oct 20, 2015 at 2:11 AM, Caesar Wang wrote: >> We need the OTP pin is gpio state before resetting the TSADC controller, >> since the tshut polarity will generate a high signal. >> >> Says: >> The TSHUT temperature is setting more than 80 degree, the default tshut >> polarity is high. >> >> If T > 80C, the OTP output the High Signal. >> If T < 80C, the OTP output the Low Signal. >> >> On the moment, the TSADC controller is reset, the tshut polarity will be >> low in a short period of time. >> So: >> >> If T < 80C, the OTP output the High Signal. >> If T > 80C, the OTP output the Low Signal. >> >> In some cases, the OTP pin is connected to the PMIC, maybe the PMIC can >> accept the reset response time to avoid this issue. >> In other words, the system will be always reboot if we make the OTP pin >> is connected the others IC to control the power. >> >> Signed-off-by: Caesar Wang >> --- >> >> drivers/thermal/rockchip_thermal.c | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) > I think you could do this with no code changes to the thermal driver > if we simply convince Linus W. to apply a change that I posted up just > about a year ago. See: > > https://patchwork.kernel.org/patch/5055741/ > > In v1 of that patch at > Linus said he liked it "A lot" and was willing to merge it with Greg > KH's Ack and with a small comment fix. I obtained the Ack and fixed > the comment, but then the patch didn't end up being needed for me and > so I never bumped it and it got lost... > > Maybe you could re-test that patch? It looks like it has a merge > conflict with current linuxnext but it looks trivial to resolve. You > could re-post my patch or I could repost it and you could add your > Tested-by. > > You'd still want to have a bindings change to describe "init", but at > least you shouldn't need any code changes. Okay, https://patchwork.kernel.org/patch/5055741/ that's working for me. Fell free add my test tag if you resend the patch. (Tested-by: Caesar Wang ) 1634ed8 FROMLIST: drivers/pinctrl: Add the concept of an "init" state 15158f8 FROMLIST: ARM: dts: rockchip: Add the OTP gpio pinctrl e7d3b88 FROMLIST: thermal: rockchip: change the TSHUT default state 184b154 FROMLIST: thermal: rockchip: ensure the otp state before resetting the controller 9edbe15 FROMLIST: dt-bindings: Sync the dts to this document Meanwhile, I change the dts as follows. - pinctrl-names = "default", "otp_out"; + pinctrl-names = "init", "default"; pinctrl-0 = <&otp_gpio>; pinctrl-1 = <&otp_out>; > > -Doug > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar