From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755851AbbJUQoH (ORCPT ); Wed, 21 Oct 2015 12:44:07 -0400 Received: from smtp65.iad3a.emailsrvr.com ([173.203.187.65]:35662 "EHLO smtp65.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbbJUQoE (ORCPT ); Wed, 21 Oct 2015 12:44:04 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <5627C0D1.7060903@mev.co.uk> Date: Wed, 21 Oct 2015 17:44:01 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Geliang Tang , H Hartley Sweeten , Greg Kroah-Hartman CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] staging: comedi: make ni_tio_has_gate2_registers return boolean References: <4e6aedb1c56b20e0a07ca100424860a5c46f1f18.1445178457.git.geliangtang@163.com> In-Reply-To: <4e6aedb1c56b20e0a07ca100424860a5c46f1f18.1445178457.git.geliangtang@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/10/15 15:35, Geliang Tang wrote: > This patch makes ni_tio_has_gate2_registers return boolean, since > this function only uses either one or zero as its return value. > > Signed-off-by: Geliang Tang > --- > drivers/staging/comedi/drivers/ni_tio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/staging/comedi/drivers/ni_tio.c > index c20c51b..b74e44e 100644 > --- a/drivers/staging/comedi/drivers/ni_tio.c > +++ b/drivers/staging/comedi/drivers/ni_tio.c > @@ -167,15 +167,15 @@ static inline unsigned GI_HW_ARM_SEL_MASK(enum ni_gpct_variant variant) > } > } > > -static int ni_tio_has_gate2_registers(const struct ni_gpct_device *counter_dev) > +static bool ni_tio_has_gate2_registers(const struct ni_gpct_device *counter_dev) > { > switch (counter_dev->variant) { > case ni_gpct_variant_e_series: > default: > - return 0; > + return false; > case ni_gpct_variant_m_series: > case ni_gpct_variant_660x: > - return 1; > + return true; > } > } > > Looks okay! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-