From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbcF0IBF (ORCPT ); Mon, 27 Jun 2016 04:01:05 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:58905 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbcF0IBD (ORCPT ); Mon, 27 Jun 2016 04:01:03 -0400 From: Arnd Bergmann To: Andreas Schwab Cc: Yury Norov , libc-alpha@sourceware.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, marcus.shawcroft@arm.com, philb@gnu.org, davem@davemloft.net, szabolcs.nagy@arm.com, maxim.kuvyrkov@linaro.org, joseph@codesourcery.com, pinskia@gmail.com, Andrew Pinski Subject: Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories. Date: Mon, 27 Jun 2016 10:03:04 +0200 Message-ID: <5629692.f1OMxVMDuj@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1466485631-3532-1-git-send-email-ynorov@caviumnetworks.com> <1466485631-3532-22-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Mb6UKwxkZ74AMn7kyqRJu0oWoThFshp9VAJJk3EuYXJbsPHee0F bso9bPSqFBKbRTXLr2AMt0Dwx2gqiK/KeFR5Dsuu6EGWUoYrcwfttdzT+gnM9I9TjFm7Pba 47S5TvC3ZCqFPIZsM5p6W5q3AtiWMMBJ6UqWHrpjfN4GFqY9rVuc2RZQU4WQa9iNUu2k7tb AdYqnvCh+Owx9CD7c/gZw== X-UI-Out-Filterresults: notjunk:1;V01:K0:W0BUtdhDVKM=:oSradvFzztNUAcPl7XYj+p OIzLSbbuSAhLHedZ6i/K8/TOBJTR66WvFx8Il3msUsUnI8MLKv0PZEPyasH1rp9QWf0GPgHeu wLWBWW+HmHEc5mFnlBjJRNhucT9CvODK6UBkgnPlsamHol+er0cWHxPgG6u/s4IiYfP4DHjvo gikx5pI53RUiTohl7RS1DMr5Izf48zpFOHWBEh0bJpo3pNT3xkoiGJqNHyjXjBsTRIy2rR8CM POFSeEZCcpwys5NN8o3FqBMtBLIDe8/6YR6b+mexR9+gYBAJQjVwUsnKiDEDl2FQM8vjQwhTi BKI+G0oy4UyRKiponQTbuxVX0tKlhyx4CusQzFXdN+Z3S1l1nVXxgkQzAIlsbZAtydkIlh/wR yT+CXD/Io7LB/BwPRdO+Yx7en1xqXXizlzUayehnnY4XHIuVLABeNRF1wdjID+QHDN99tBx1p +mCiDRpfEkl5+mPmBDlVhDSCIK8pcVtN7SbYT96n+KXAv7QnX8ctWOtEclJOMzGHhx64HgyXv pqMl/k3kLYkvYiLrhVFztyY/x9aFX4gCL3CO75LsS7pYrGUfpRTGXka39YXtc03NRQ/GeWtIZ uTSGR0zZJ8AsPR+gPYctzg50KtqkMt63mPBhDYSi6Uys78EsKELeEliCEEREi7A5bXEn2cXpe 0PRBH8RrRIyC7bvrVxMNdjoCpXDotQDxI72F972jzqhZpgnBtYDUsb6lNC5z3gu+lQ2sa9Lr8 lEAvmyUDp9DXTLDxuMzYgrkHAJrWMIIxoKANNYRMf2fSERF4Pd55HLV3kMSPVQSxVJTVDArfo kqxREPCW80+Uy8mxERRyrfw9ekXQQeLJBVaXtfrfROKN5bPhhzrQwEfAjSHpK64wSXcLQL3Lg 8zoJ/bO7eeKoRPFBwGkXIs/SABep6GOVotEniIHwlTpZ8iozXWIlcQECjd8vgs Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, June 27, 2016 9:56:13 AM CEST Andreas Schwab wrote: > Yury Norov writes: > > > diff --git a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h > > index 658f696..7dcbe65 100644 > > --- a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h > > +++ b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h > > @@ -25,7 +25,11 @@ > > #define __O_NOFOLLOW 0100000 > > #define __O_DIRECT 0200000 > > > > -#define __O_LARGEFILE 0 > > +#ifdef __ILP32__ > > +# define __O_LARGEFILE 0400000 > > +#else > > +# define __O_LARGEFILE 0 > > +#endif > > Is there any point in defining O_LARGEFILE to non-zero if the kernel is > enforcing it anyway? The kernel might want to return -EINVAL for undefined flags. I'm not sure if we want to do that here, but it would seem like a correct return code. Arnd