From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966147AbbJWBNF (ORCPT ); Thu, 22 Oct 2015 21:13:05 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:47433 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965481AbbJWBND (ORCPT ); Thu, 22 Oct 2015 21:13:03 -0400 Subject: Re: [PATCH -next] mtd: fsl-quadspi: Never build on SPARC To: Brian Norris , Han Xu References: <1445437906-23633-1-git-send-email-linux@roeck-us.net> <20151023010757.GI13239@google.com> Cc: David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <5629899C.5040404@roeck-us.net> Date: Thu, 22 Oct 2015 18:13:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151023010757.GI13239@google.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2015 06:07 PM, Brian Norris wrote: > + Han > > On Wed, Oct 21, 2015 at 07:31:46AM -0700, Guenter Roeck wrote: >> Attempts to build fsl-quadspi on SPARC fail with >> >> drivers/mtd/spi-nor/fsl-quadspi.c: In function 'fsl_qspi_init_lut': >> drivers/mtd/spi-nor/fsl-quadspi.c:369:1: error: >> 'LUT_0' undeclared (first use in this function) >> drivers/mtd/spi-nor/fsl-quadspi.c:418:1: error: >> pasting "LUT_" and "(" does not give a valid preprocessing token >> drivers/mtd/spi-nor/fsl-quadspi.c:418:2: error: >> implicit declaration of function 'LUT_' > > I don't think this is only a SPARC problem. The macro concatenation is > generally suspect. > > I see that READ and WRITE are problems at least. If something like > gets included somehow, then these tokens resolve to > integers or expressions before they fall through to literal > concatentation, so we get 'LUT_0' or 'LUT_(1ULL << __REQ_WRITE)' instead > of 'LUT_READ' and 'LUT_WRITE'. > You are right, that deserves a better fix. I'll leave it up to you. Thanks, Guenter