mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Selvarasu Ganesan <selvarasu.g@samsung.com>,
	peter.griffin@linaro.org, alim.akhtar@samsung.com,
	gregkh@linuxfoundation.org, robh@kernel.org, conor+dt@kernel.org,
	Thinh.Nguyen@synopsys.com, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jh0801.jung@samsung.com, dh10.jung@samsung.com,
	akash.m5@samsung.com, hongpooh.kim@samsung.com,
	eomji.oh@samsung.com, shijie.cai@samsung.com,
	muhammed.ali@samsung.com, thiagu.r@samsung.com
Subject: Re: [PATCH 2/3] dt-bindings: usb: Introduce samsung,snps-dwc3
Date: Mon, 7 Sep 2026 09:07:39 +0200	[thread overview]
Message-ID: <5629de34-1a63-40bf-8375-64be9a69eea2@kernel.org> (raw)
In-Reply-To: <e4bafeea-4548-41ef-b5e2-98ade2864e74@samsung.com>

On 07/09/2026 08:04, Selvarasu Ganesan wrote:
> 
> On 9/5/2026 12:52 PM, Krzysztof Kozlowski wrote:
>> On 03/09/2026 09:12, Selvarasu Ganesan wrote:
>>> The Samsung Exynos8855 USB glue is not separate from the Synopsys DWC3
>>> core, using a flattened model where the DWC3 controller is directly
>>> addressable rather than nested as a child node of a glue layer.
>>>
>>> Describe the Exynos USB block as a single node, referencing the split
>>> out Synopsys DWC3 core properties via snps,dwc3-common.yaml. The new
>>> binding follows the same approach as qcom,snps-dwc3.
>>>
>>> A generic fallback compatible "samsung,snps-dwc3" is introduced to
>>> describe this binding, selected by the validator based on the presence
>>> of the fallback string in the compatible list. Future Exynos SoCs
>> This is AI slop text. Over longish useless sentence describing diff
>> without actual information WHY.
>>
>> Don't send AI generated slop messages.
> 
> Sorry for the misleading info on this commit message. We were trying to 
> explain why a separate flattened representation is being introduced with 
> using generic fallback string, and follow the style of some other DWC3 
> flattened refactors (like the Qualcomm : 
> https://lore.kernel.org/all/20250414-dwc3-refactor-v7-2-f015b358722d@oss.qualcomm.com) 
> to justify the separate binding, but it became too long. We'll simplify 
> it and keep only the technical reasoning.

Flattened node is the right approach, so just say this is the first
Samsung Exynos binding using flattened node.


Best regards,
Krzysztof

  reply	other threads:[~2026-09-07  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260903071311epcas5p24c547d69b769818834ae2b7285cb541b@epcas5p2.samsung.com>
2026-09-03  7:12 ` [PATCH 0/3] Add USB DWC3 support for Samsung Exynos8855 Selvarasu Ganesan
     [not found]   ` <CGME20260903071314epcas5p2bf6f08797b9b92aef2bbd5a6a2708867@epcas5p2.samsung.com>
2026-09-03  7:12     ` [PATCH 1/3] MAINTAINERS: add Samsung USB DT binding to ARM/SAMSUNG entry Selvarasu Ganesan
     [not found]   ` <CGME20260903071318epcas5p4b804edb84554847c576d1d034b814d7a@epcas5p4.samsung.com>
2026-09-03  7:12     ` [PATCH 2/3] dt-bindings: usb: Introduce samsung,snps-dwc3 Selvarasu Ganesan
2026-09-05  7:22       ` Krzysztof Kozlowski
2026-09-07  6:04         ` Selvarasu Ganesan
2026-09-07  7:07           ` Krzysztof Kozlowski [this message]
2026-09-07  8:50             ` Selvarasu Ganesan
     [not found]   ` <CGME20260903071322epcas5p2a40e3299b0954dd880c9b3651555760c@epcas5p2.samsung.com>
2026-09-03  7:12     ` [PATCH 3/3] usb: dwc3: Add Exynos8855 to the generic platform driver Selvarasu Ganesan
2026-09-05  0:15       ` Thinh Nguyen
2026-09-05  7:19       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5629de34-1a63-40bf-8375-64be9a69eea2@kernel.org \
    --to=krzk@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=akash.m5@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dh10.jung@samsung.com \
    --cc=eomji.oh@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hongpooh.kim@samsung.com \
    --cc=jh0801.jung@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=muhammed.ali@samsung.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=selvarasu.g@samsung.com \
    --cc=shijie.cai@samsung.com \
    --cc=thiagu.r@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®