From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753693AbbJZL10 (ORCPT ); Mon, 26 Oct 2015 07:27:26 -0400 Received: from smtp-out-225.synserver.de ([212.40.185.225]:1057 "EHLO smtp-out-188.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753432AbbJZL1Y (ORCPT ); Mon, 26 Oct 2015 07:27:24 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 8728 Message-ID: <562E0E18.80500@metafoo.de> Date: Mon, 26 Oct 2015 12:27:20 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Robert Jarzmik , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai CC: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap References: <1445722627-28854-1-git-send-email-robert.jarzmik@free.fr> In-Reply-To: <1445722627-28854-1-git-send-email-robert.jarzmik@free.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2015 11:37 PM, Robert Jarzmik wrote: [...] > -static unsigned int ac97_read(struct snd_soc_codec *codec, > - unsigned int reg); > -static int ac97_write(struct snd_soc_codec *codec, > - unsigned int reg, unsigned int val); For review purposes it would be helpful to split this into two patches. One performing the regmap conversion the other replacing ac97_read()/ac97_write() with the matching snd_soc_ calls (or snd_soc_update_bits). > + snd_soc_codec_init_regmap(codec, regmap); You need to call snd_soc_odec_exit_regmap() when the CODEC is unbound.