From: "Wangnan (F)" <wangnan0@huawei.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
pi3orama <pi3orama@163.com>
Cc: <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@plumgrid.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Li Zefan <lizefan@huawei.com>
Subject: Re: [RFC PATCH] perf tools: Don't set inherit bit for system wide evsel
Date: Mon, 26 Oct 2015 19:48:59 +0800 [thread overview]
Message-ID: <562E132B.7080407@huawei.com> (raw)
In-Reply-To: <562DF19B.2080608@intel.com>
On 2015/10/26 17:25, Adrian Hunter wrote:
> On 26/10/15 11:08, Wangnan (F) wrote:
>>
>> evsel->system_wide is introduced by commit
>> bf8e8f4b832972c76d64ab2e2837a48397144887
>> (perf evlist: Add 'system_wide' option), but Adrian only introduced a new field
>> into perf, doesn't really make it active. Until now the only user of it is
>> arch/x86/util/intel-pt.c, but I'm not very sure the reason for IPT to use that
>> field.
>>
>> If I understand correctly, it should be okay for a normal system wide evsel
>> to have
>> this var set. I'll try another RFC for it.
> evsel->system_wide is for mixing evsels that aren't system-wide with ones
> that are.
>
> It might work to set it for all system-wide evsels but you will have to
> check the code and test it, because that would be using it in a new way
> that has never been tested.
I have check all occurance of system_wide I can found and found
only one behavior change which I believe should be okay. Please
have a look at [1].
Thank you.
[1]
http://lkml.kernel.org/g/1445859720-146146-1-git-send-email-wangnan0@huawei.com
prev parent reply other threads:[~2015-10-26 11:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 10:43 Wang Nan
2015-10-23 13:51 ` Arnaldo Carvalho de Melo
2015-10-23 13:58 ` pi3orama
2015-10-23 16:17 ` Arnaldo Carvalho de Melo
2015-10-26 9:08 ` Wangnan (F)
2015-10-26 9:25 ` Adrian Hunter
2015-10-26 11:48 ` Wangnan (F) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E132B.7080407@huawei.com \
--to=wangnan0@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ast@plumgrid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=pi3orama@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome