From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbbJ0C3c (ORCPT ); Mon, 26 Oct 2015 22:29:32 -0400 Received: from sf1.bxl.stone.is ([87.238.167.223]:45420 "EHLO sf1.bxl.stone.is" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753821AbbJ0C3a (ORCPT ); Mon, 26 Oct 2015 22:29:30 -0400 X-Greylist: delayed 1936 seconds by postgrey-1.27 at vger.kernel.org; Mon, 26 Oct 2015 22:29:30 EDT Subject: Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code To: Peter Oberparleiter , "James E.J. Bottomley" References: <562E3E9F.50600@linux.vnet.ibm.com> Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org From: Bart Van Assche Message-ID: <562ED9E0.7050603@acm.org> Date: Mon, 26 Oct 2015 18:56:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562E3E9F.50600@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <20151027015651.827876.81651@vz23.stone-is.net> X-PPP-Vhost: bartvanassche.be X-Filter-ID: s0sct1PQhAABKnZB5plbIYrcAt68paBzxGNV4bZScc8DDDH9IcRzs4ldqK5vEMwbuZt+PpRPW1h0 yigPev+a+/OjA7kCJ+pEgO99Tr6bXdBBNCWKxoG8EhGkaqtAcgGDMeGK/A9AcQq2N5f+LnoQfILS 2uzVVSoW6lDwGaRWF+J8LN00Y2guNhbTSbk1sIe8n/akrIr5OVyoLv1bNTWMp7fAvZjgXTjXZ7MY LJNQ9qc7Zy+8mw8YAqwC2gr4xU/KCzR2CLGX4aclzH/0UNSg6Yc41LCVHV6FBYWQjJWIHTd+fqwz YpGa+BTvL5f6KSlhUV8ShebT8U8Xw9HTDfreWciaX+HqPLeRZfMv62nIewkFK/Y1/a8UvKlIfjWa FN154AFOV4xqoSqvp78RIszsFdgQ5idB19qE/5w8pM4y+NC8jyW/BoP9x/cUAw2qVsDRBsP8KAdG 7qxDrQaDkDXskHnc5QoRGUursPbMAuzbWQP6DupCze1TXt4EbagryYyJ+1d9ZEvBSryt/wycK4xG /gYhXIgOJM4MGW1jvzKL8Xk21Cee63EeltfbuaMMNA5XChP/unfOgBSCviVedjY3z2yD3x7GpU/g AeuLEzs5kz7pFqwWLH+m+GSR7WPmQKThNtQnnutxHpbX27mjDDQOVzQ8Nui7P/LliFeBbsy0MOcf S93xRmaZXfl6/KPgcpqcStoVmQmHSiSmfyAGV3VD+TTrMhIvsABFxf/3t900k5rGZ7uitKFQvA9C WJFgTP40MS+4ayUpOtEhdxekWDmK9g== X-Report-Abuse-To: spam@sf1.bxl.stone.is X-Filter-Fingerprint: IFrWXGses7OKB5S5G8/dJRn/7L7+nnclbWGk7OJ1jHJA3cTUQ1R++keuE7RDJ8Kg3RbMLUalw1oC mj99/u+PoqoVy8a3lsStJtAvpObFX0Wok1JBYnOLzfRIhlEHQynLRwQd5Deh21btrUTI2ioQbbwN kORlIFJ73KEwNYCGVrVZSROtr3ifX2fA1tkOpx99QeauqoR+R79FHMPxe85QA6yWUY3/abmMn4j/ gEgeKuqK+7TOGN858irXMGlaHsJ+RCAdYMWd2ToQ1wmy5CWzTw== X-Originating-IP: 87.238.162.216 X-SpamExperts-Domain: stone.is X-SpamExperts-Username: 87.238.162.216 Authentication-Results: bxl.stone.is; auth=pass smtp.auth=87.238.162.216@stone.is X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.02) X-Recommended-Action: accept Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/15 07:54, Peter Oberparleiter wrote: > Writing a number to /sys/bus/scsi/devices//queue_ramp_up_period > returns the value of that number instead of the number of bytes written. > This behavior can confuse programs expecting POSIX write() semantics. > Fix this by returning the number of bytes written instead. > > Signed-off-by: Peter Oberparleiter > --- > drivers/scsi/scsi_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > index b333389..6b0f292 100644 > --- a/drivers/scsi/scsi_sysfs.c > +++ b/drivers/scsi/scsi_sysfs.c > @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev, > return -EINVAL; > > sdev->queue_ramp_up_period = msecs_to_jiffies(period); > - return period; > + return count; > } > > static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR, Hello Peter, Good catch. But please CC the people who introduced this code and also "stable" (see also commit 4a84067dbfce436b81779e585bf712b02ceee552). Thanks, Bart.