From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273AbbJ0IRE (ORCPT ); Tue, 27 Oct 2015 04:17:04 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:27482 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753590AbbJ0IRA (ORCPT ); Tue, 27 Oct 2015 04:17:00 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-35-562f32f9fc3b Message-id: <562F32F8.6050701@samsung.com> Date: Tue, 27 Oct 2015 09:16:56 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Fida Mohammad Cc: Bryan Wu , Richard Purdie , linux-leds@vger.kernel.org, LKML , Muhammad Falak , Kristoffer Subject: Re: [PATCH] leds: leds-hp6xx: Use of devm_classdev_register References: <1445878828-32514-1-git-send-email-fmthoker@gmail.com> In-reply-to: <1445878828-32514-1-git-send-email-fmthoker@gmail.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xq7o/jfTDDJZeNrA4unMik8Xuh+dZ LVZ/f8lkMe+khMXlXXPYLLa+WcdosXvXU1YHdo+ds+6ye+yZ/4PV4/MmuQDmKC6blNSczLLU In27BK6MC2c+sRU08FbMebOEvYHxBFcXIyeHhICJROf6PlYIW0ziwr31bF2MXBxCAksZJf5+ WsEEkhASeMYosfVSMojNK6Al8WfPLWYQm0VAVWLXk0dgNpuAocTPF6/B6kUFIiT+nN7HClEv KPFj8j0WEFtEQE3i8pI/LCALmAXuMUpM2zCDvYuRg0NYwFXi3WMpiF1OEu2NP9hBbE4BZ4mV a/aB9TILWEusnLSNEcKWl9i85i3zBEaBWUhWzEJSNgtJ2QJG5lWMoqmlyQXFSem5hnrFibnF pXnpesn5uZsYIeH8ZQfj4mNWhxgFOBiVeHgNKvTChFgTy4orcw8xSnAwK4nwCurohwnxpiRW VqUW5ccXleakFh9ilOZgURLnnbvrfYiQQHpiSWp2ampBahFMlomDU6qBMTyCrSfyeGVKvGWe xiX33aWFAdtnKLJMzWxeGNESc+BQh6tru8mDBxf5Jh/0/uekymctZiiypeCs4Aa/9TXlT2J6 BBl1/CpvzmHN3PTKS/20Bs8Ha7Pmh8ws0zWiRRd7dFq79178ziPmfry1ZW3kPnsh7eo0n51K RVn3XrMk3Z+qv8zfNkmJpTgj0VCLuag4EQAToNInYwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fida, Thanks for the patch. It doesn't apply smoothly, though. Please rebase the patch on the top of LED git tree [1], for-next branch. [1] git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git Best Regards, Jacek Anaszewski On 10/26/2015 06:00 PM, Fida Mohammad wrote: > Use resource managed function devm_classdev_register to make > error path simpler. Also removed the redundant remove function. > > Signed-off-by: Fida Mohammad > --- > drivers/leds/leds-hp6xx.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/leds/leds-hp6xx.c b/drivers/leds/leds-hp6xx.c > index 0b84c01..ffb6d5b 100644 > --- a/drivers/leds/leds-hp6xx.c > +++ b/drivers/leds/leds-hp6xx.c > @@ -59,28 +59,17 @@ static int hp6xxled_probe(struct platform_device *pdev) > { > int ret; > > - ret = led_classdev_register(&pdev->dev, &hp6xx_red_led); > + ret = devm_led_classdev_register(&pdev->dev, &hp6xx_red_led); > if (ret < 0) > return ret; > > - ret = led_classdev_register(&pdev->dev, &hp6xx_green_led); > - if (ret < 0) > - led_classdev_unregister(&hp6xx_red_led); > + return devm_led_classdev_register(&pdev->dev, &hp6xx_green_led); > > - return ret; > } > > -static int hp6xxled_remove(struct platform_device *pdev) > -{ > - led_classdev_unregister(&hp6xx_red_led); > - led_classdev_unregister(&hp6xx_green_led); > - > - return 0; > -} > > static struct platform_driver hp6xxled_driver = { > .probe = hp6xxled_probe, > - .remove = hp6xxled_remove, > .driver = { > .name = "hp6xx-led", > }, >