From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932515AbbJ0OQE (ORCPT ); Tue, 27 Oct 2015 10:16:04 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:36252 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932219AbbJ0OQB (ORCPT ); Tue, 27 Oct 2015 10:16:01 -0400 Subject: Re: [PATCH 1/2] serial: 8250_ingenic: delete redundant "select SERIAL_EARLYCON" To: Masahiro Yamada , linux-serial@vger.kernel.org References: <1445607076-14135-1-git-send-email-yamada.masahiro@socionext.com> Cc: Paul Burton , Sebastian Andrzej Siewior , Jiri Slaby , linux-kernel@vger.kernel.org, Andy Shevchenko , Joachim Eastwood , John Crispin , Greg Kroah-Hartman , Ralf Baechle From: Peter Hurley Message-ID: <562F871D.4060401@hurleysoftware.com> Date: Tue, 27 Oct 2015 10:15:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445607076-14135-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2015 09:31 AM, Masahiro Yamada wrote: > SERIAL_8250_INGENIC depends on SERIAL_8250_CONSOLE, which already > selects SERIAL_EARLYCON. > > This line is redundant. Reviewed-by: Peter Hurley