From: Jared McArthur <j-mcarthur@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Tero Kristo <kristo@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0
Date: Tue, 30 Jul 2024 16:04:49 -0500 [thread overview]
Message-ID: <56306559-7f30-47f2-a6c6-bace35fc77c5@ti.com> (raw)
In-Reply-To: <20240730145956.n7brt337sc5vjpg5@violet>
On 7/30/24 09:59, Nishanth Menon wrote:
> On 09:33-20240730, Jared McArthur wrote:
>> Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges
>> properties") introduced pinmux range definition for gpio-ranges,
>> however missed introducing the range description for the mcu_gpio0
>> node. As a result, automatic mapping of GPIO to pin control for mcu
>> gpios is broken. Fix this by introducing the proper ranges.
>>
>> Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties")
>> Signed-off-by: Jared McArthur <j-mcarthur@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
>> index e65db6ce02bf..c0bdbd00dc23 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
>> @@ -146,6 +146,9 @@ mcu_gpio0: gpio@4201000 {
>> power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>;
>> clocks = <&k3_clks 79 0>;
>> clock-names = "gpio";
>> + gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>,
>> + <&mcu_pmx0 22 32 2>;
>> + ti,ngpio = <24>;
> we already have ti,ngpio - please drop
Sorry, missed that. I will fix it and resend the patch.
>> };
>>
>> mcu_rti0: watchdog@4880000 {
>> --
>> 2.34.1
>>
--
Best,
Jared McArthur
next prev parent reply other threads:[~2024-07-30 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 14:33 [PATCH 0/3] arm64: dts: ti: k3-am62p/j722s: Fix gpio-ranges Jared McArthur
2024-07-30 14:33 ` [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0 Jared McArthur
2024-07-30 14:59 ` Nishanth Menon
2024-07-30 21:04 ` Jared McArthur [this message]
2024-07-30 14:33 ` [PATCH 2/3] arm64: dts: ti: k3-am62p: Fix gpio-range for main_pmx0 Jared McArthur
2024-07-30 14:33 ` [PATCH 3/3] arm64: dts: ti: k3-j722s: " Jared McArthur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56306559-7f30-47f2-a6c6-bace35fc77c5@ti.com \
--to=j-mcarthur@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®