From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755758AbbJ1LCy (ORCPT ); Wed, 28 Oct 2015 07:02:54 -0400 Received: from lists.s-osg.org ([54.187.51.154]:53512 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbbJ1LCw (ORCPT ); Wed, 28 Oct 2015 07:02:52 -0400 Subject: Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler To: Ulf Hansson References: <1445440540-21525-1-git-send-email-javier@osg.samsung.com> Cc: "linux-kernel@vger.kernel.org" , Markus Reichl , Anand Moon , linux-samsung-soc , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , linux-mmc , Alexandre Courbot From: Javier Martinez Canillas Message-ID: <5630AB57.4030405@osg.samsung.com> Date: Wed, 28 Oct 2015 12:02:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Ulf, On 10/27/2015 11:10 AM, Ulf Hansson wrote: > On 21 October 2015 at 17:15, Javier Martinez Canillas > wrote: >> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >> allow broken or limited ROM boot-loaders (that don't have an eMMC reset >> logic) to be able to read the second stage from the eMMC. >> >> But this has to be called before a system reboot handler and while most >> of them use the priority 128, there are other restart handlers (such as >> the syscon-reboot one) that use a higher priority. So, use the highest >> priority to make sure that the eMMC hw is reset before a system reboot. >> >> Signed-off-by: Javier Martinez Canillas >> Tested-by: Markus Reichl >> Tested-by: Anand Moon >> Reviewed-by: Alim Akhtar >> >> --- >> Hello, >> >> This patch was needed since a recent series from Alim [0] added >> syscon reboot and poweroff support to Exynos SoCs and removed >> the reset handler in the Exynos Power Management Unit (PMU) code. >> >> But the PMU and syscon-reboot restart handler have a different >> priority so [0] breaks restart when eMMC is used on these boards. >> >> [0]: http://www.spinics.net/lists/arm-kernel/msg454396.html >> >> So this patch must be merged before [0] to avoid regressions. >> >> Best regards, >> Javier > > So it seems like there have been a good discussion around this. I > don't have any objections, but is more concerned about potential > regressions. > Yes, there was a lot of discussion indeed but it seems we all agree on the approach and that the patch should not land before having a lot of testing. > I have queued it up for next (4.4) so we get some testing in > linux-next. If anyone have issues, please report them. > great, some weeks sitting in -next to let the CI infrastructure to play with it seems reasonable to me. Thanks a lot! > Kind regards > Uffe > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America