From: "Lu, Baolu" <baolu.lu@linux.intel.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs
Date: Thu, 29 Oct 2015 09:18:58 +0800 [thread overview]
Message-ID: <56317402.502@linux.intel.com> (raw)
In-Reply-To: <1446024421.15140.6.camel@suse.com>
On 10/28/2015 05:27 PM, Oliver Neukum wrote:
>> +static int fill_buffer(struct debug_buffer *buf)
>> >+{
>> >+ int ret;
>> >+
>> >+ if (buf->output_buf)
>> >+ return -EINVAL;
>> >+
>> >+ buf->alloc_size = PAGE_SIZE;
>> >+ buf->output_buf = vmalloc(buf->alloc_size);
> That really makes no sense. If you allocate exactly
> PAGE_SIZE, you should allocate a page.
Yes, I will change it in v2.
>
> Regards
> Oliver
Thanks,
Baolu
>
>
>
next prev parent reply other threads:[~2015-10-29 1:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 8:00 [PATCH 00/12] usb: early: add support for early printk through USB3 debug port Lu Baolu
2015-10-28 8:00 ` [PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs Lu Baolu
2015-10-28 9:27 ` Oliver Neukum
2015-10-29 1:18 ` Lu, Baolu [this message]
2015-10-28 12:40 ` Greg Kroah-Hartman
2015-10-29 1:22 ` Lu, Baolu
2015-10-30 12:09 ` Lu, Baolu
2015-10-30 14:45 ` Greg Kroah-Hartman
2015-11-02 13:07 ` Lu, Baolu
2015-10-28 8:00 ` [PATCH 02/12] x86: fixmap: add permanent fixmap for xhci debug port Lu Baolu
2015-10-28 8:00 ` [PATCH 03/12] usb: xhci: dbc: probe and setup xhci debug capability Lu Baolu
2015-10-28 8:00 ` [PATCH 04/12] usb: xhci: dbc: add support for Intel xHCI dbc quirk Lu Baolu
2015-10-28 8:00 ` [PATCH 05/12] usb: xhci: dbc: add debug buffer Lu Baolu
2015-10-28 8:00 ` [PATCH 06/12] usb: xhci: dbc: add bulk out and bulk in interfaces Lu Baolu
2015-10-28 8:00 ` [PATCH 07/12] usb: xhci: dbc: handle dbc-configured exit Lu Baolu
2015-10-28 8:00 ` [PATCH 08/12] usb: xhci: dbc: handle endpoint stall Lu Baolu
2015-10-28 8:00 ` [PATCH 09/12] x86: early_printk: add USB3 debug port earlyprintk support Lu Baolu
2015-10-28 8:00 ` [PATCH 10/12] usb: xhci: dbc: add handshake between debug target and host Lu Baolu
2015-10-28 8:00 ` [PATCH 11/12] usb: serial: usb_debug: add support for dbc debug device Lu Baolu
2015-10-28 9:10 ` Johan Hovold
2015-10-29 1:24 ` Lu, Baolu
2015-10-28 12:33 ` Greg Kroah-Hartman
2015-10-29 1:43 ` Lu, Baolu
2015-10-30 11:46 ` Lu, Baolu
2015-10-30 14:41 ` Greg Kroah-Hartman
2015-10-31 5:37 ` Lu, Baolu
2015-10-28 8:00 ` [PATCH 12/12] usb: doc: add document for xHCI DbC driver Lu Baolu
2015-11-03 9:42 ` [PATCH 00/12] usb: early: add support for early printk through USB3 debug port Dave Young
2015-11-04 0:40 ` Lu, Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56317402.502@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome