From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756732AbbJ2GZL (ORCPT ); Thu, 29 Oct 2015 02:25:11 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51054 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756692AbbJ2GZH (ORCPT ); Thu, 29 Oct 2015 02:25:07 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-02-5631bbc04f0e Subject: Re: [PATCH 0/3] ARM: dts: Enable Exynos RNG module To: Tobias Jakobi , Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Matt Mackall , Herbert Xu , linux-crypto@vger.kernel.org References: <1445230834-32689-1-git-send-email-k.kozlowski@samsung.com> <56251627.4050908@math.uni-bielefeld.de> <562581BD.3070609@samsung.com> <562C1B17.3080303@math.uni-bielefeld.de> Cc: Heiner Kallweit From: Krzysztof Kozlowski Message-id: <5631BBB6.9080204@samsung.com> Date: Thu, 29 Oct 2015 15:24:54 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <562C1B17.3080303@math.uni-bielefeld.de> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t/xK7oHdhuGGRzewGsx/8g5VovuVzIW i97PYLV4/cLQov/xa2aLTY+vsVp87LnHanH/3k8mi8u75rBZzDi/j8liwbY+RouLp1wtDr9p Z7X4caabxaJt9QdWi1W7/jA6CHi8v9HK7nG5r5fJY+esu+we2w6oemxa1cnmsXlJvce/Y+we fVtWMXr0vdzA6PF5k1wAVxSXTUpqTmZZapG+XQJXxqr7igVHuSpuXn7B2sC4hqOLkZNDQsBE 4mT3ImYIW0ziwr31bCC2kMBSRonTO/gg7C+MEpemK4DYwgLWEj+m/QOq5+IQEehikfg/ZS0L iCMksIdRoufDInaQKmYBLYlHn6ewgthsAsYSm5cvAZvKCxR/P28dmM0ioCrRPGsRC4gtKhAh MXFCAytEjaDEj8n3gOIcHJwCphLzf4WBmMwC6hJTpuRCTJeX2LzmLfMERoFZSBpmIVTNQlK1 gJF5FaNoamlyQXFSeq6hXnFibnFpXrpecn7uJkZIfH3Zwbj4mNUhRgEORiUe3gVGhmFCrIll xZW5hxglOJiVRHilWYBCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeefueh8iJJCeWJKanZpakFoE k2Xi4JRqYAzdcD4p/4LXhfYV67WTlsfk909jYnaozr99sIVN+FAcw67bOuHSehMXu6oFGU7X 90tpkHV1tY9VqZdLOKdyjG3HGRnn+7uXP5nx2nfdaX3+a/fjjGMC2W66Tz+SvrKjs+QOw5aX R5h85O6mVf0tXjBN8dj6b7avjp9Zcunm7+DMrweyql685FFiKc5INNRiLipOBAAtsy2GqwIA AA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25.10.2015 08:58, Tobias Jakobi wrote: > Hello Krzysztof, > > > Krzysztof Kozlowski wrote: >> On 20.10.2015 01:11, Tobias Jakobi wrote: >>> Hello Krzysztof, >>> >>> I can confirm that this also works on a Odroid-X2, so I guess it's safe >>> to enable the PRNG for all Exynos4412-based Odroid devices. >> >> Sure, I can send a patch for that. I can test it later also on Odroid-U3. > Thanks already! > > > >>> Any chance that you might also take a look at the other hwcrypto stuff >>> on the SoC ('samsung,exynos4210-secss' compatible)? >> >> What do you mean? The s5p-sss driver already supports Device Tree. > The driver supports DT, but it doesn't really work. > > I'm using the following DT entry to let the driver probe correctly: > https://github.com/tobiasjakobi/linux-odroid/commit/82c00cddb5cbf89fad994784c28c8125beae8e13 > > But the crypto self-test fails on boot: > alg: skcipher: encryption failed on test 1 for ecb-aes-s5p: ret=22 > > > Another problems is that SSS and PRNG can't be used at the same time, > since they both use common hardware resources (I think it was IO). > Thanks for explaining this. I added the issue to the long TODO list but I don't know when I will be able to dig into this. If anyone wants to look into this, please go ahead... Best regards, Krzysztof