From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758813AbbJ3HXQ (ORCPT ); Fri, 30 Oct 2015 03:23:16 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:49759 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758527AbbJ3HXN (ORCPT ); Fri, 30 Oct 2015 03:23:13 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-20-56331ade2767 Subject: Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration To: Pavel Fedin , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <56330E6E.50003@samsung.com> <00a101d112e0$537a18e0$fa6e4aa0$@samsung.com> Cc: "'Rob Herring'" , "'Pawel Moll'" , "'Mark Rutland'" , "'Ian Campbell'" , "'Kumar Gala'" , "'Kukjin Kim'" From: Krzysztof Kozlowski Message-id: <56331ADB.1070602@samsung.com> Date: Fri, 30 Oct 2015 16:23:07 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <00a101d112e0$537a18e0$fa6e4aa0$@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNLMWRmVeSWpSXmKPExsVy+t/xq7r3pIzDDO78NbWYf+Qcq0X/m4Ws FuderWS0eP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TBZLr19ksnh1aRWbxYTpa1ksWvceYXfg 8Vgzbw2jx+W+XiaPlcu/sHlsWtXJ5rF5Sb1H35ZVjB6fN8kFsEdx2aSk5mSWpRbp2yVwZfQ8 2cxWsEew4teL22wNjP95uhg5OCQETCSudbB1MXICmWISF+6tB7OFBJYyStxel9vFyAVkf2GU +PHsBitIQlggTGLLkQ52kISIwBpGieXnDjJCVF1mlNjROp8ZxGEWeMMocWrZY2aQFjYBY4nN y5eAzeUV0JJ48XMBG8hqFgFViQnvAkHCogIREhMnNLBClAhK/Jh8jwXE5hSwkng1aQtYObOA nsT9i1ogYWYBeYnNa94yT2AUmIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn 525ihETJlx2Mi49ZHWIU4GBU4uH9kWAUJsSaWFZcmXuIUYKDWUmE9/cloBBvSmJlVWpRfnxR aU5q8SFGaQ4WJXHeubvehwgJpCeWpGanphakFsFkmTg4pRoYLdhtP5yt29QksvP5D+OFveY1 mcwOMxj06w4tWCUWnnz+LueZ3Ucnr/A4db9xjoNoCpezhckkFq2GeysuNTXVTpybYMz36J6Q 3MZn8+6/9ON7uW/e6jLG2Lu6B+3nMfx9qx608N7nrXOdvsxaav0yJcopxLdZhqPh06EEA9a7 bVecWC/ry+65ocRSnJFoqMVcVJwIABkLjsqOAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.10.2015 15:58, Pavel Fedin wrote: > Hello! > >>> Add documentation for new subnode properties, allowing bank configuration. >>> Based on u-boot implementation, but heavily reworked. >> >> Please, carefully look at: >> Documentation/devicetree/bindings/net/gpmc-eth.txt >> Documentation/devicetree/bindings/bus/ti-gpmc.txt > > Thank you very much. Indeed, this looks very similar. By the way, should i document smsc over sromc in the same manner, writing > devicetree/bindings/net/sromc-eth.txt? > > This is a short reply for now, i'll make longer one (or just a new version) after studying these existing bindings and trying to > apply them. Existing SROMC bindings document is small so one document for everything should be sufficient. This can be always split if new type of devices will be using SROMC (BTW, do you know of any other devices using SROMC on Exynos?). > > Pankaj: > >>> +&sromc { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&srom_ctl>, <&srom_ebi>; >>> + >>> + ethernet@07000000 { >>> + compatible = "smsc,lan9115"; >>> + reg = <0x07000000 0x10000>; >>> + phy-mode = "mii"; >>> + interrupt-parent = <&gpx0>; >>> + interrupts = <5 8>; >>> + reg-io-width = <2>; >>> + smsc,irq-push-pull; >>> + smsc,force-internal-phy; >>> + >>> + samsung,srom-bank = <3>; >>> + samsung,srom-data-width = <2>; >>> + samsung,srom-timing = <1 9 12 1 9 1 1>; >> >> I think this is not correct. We can't change binding of "smsc,lan9115" >> which is already documented here [1]. These samsung specific srom >> properties should be in srom node or its subnode, but not in this way. > > So, if you look at gpmc-eth.txt, you'll see that this approach is perfectly valid (this is a reply to another msg, just don't want > to post one more single-line reply). Yes, the binding of smsc,lan9115 is not changed. Putting srom properties in separate bank node would be good also but then some mapping (connection) between ethernet and bank should be added probably... Best regards, Krzysztof