From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030987AbbJ3Ls5 (ORCPT ); Fri, 30 Oct 2015 07:48:57 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:35687 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030875AbbJ3Lsz (ORCPT ); Fri, 30 Oct 2015 07:48:55 -0400 Subject: Re: [PATCH] Revert "h8300: clocksource" To: Arnd Bergmann References: <1446200775-23898-1-git-send-email-daniel.lezcano@linaro.org> <7633294.svub55eV7t@wuerfel> Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Yoshinori Sato , "open list:OPEN FIRMWARE AND..." , "moderated list:H8/300 ARCHITECTURE" From: Daniel Lezcano Message-ID: <56335924.408@linaro.org> Date: Fri, 30 Oct 2015 12:48:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <7633294.svub55eV7t@wuerfel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2015 12:19 PM, Arnd Bergmann wrote: > On Friday 30 October 2015 11:26:08 Daniel Lezcano wrote: >> This reverts commit 618b902d8c098f2fff188119da7b3184c4bc5483. [ ... ] > I found that Yoshinori Sato has always addressed all review comments very > quickly by rewriting the code in a proper manner when mistakes were > pointed out in the other drivers. Maybe you can describe now what the > problems are with the three drivers to give him a chance to fix them? I agree it is a good argument to give him the opportunity to fix the code. Yoshinori Sato, can you please do a cleanup in the init functions to comply with the other drivers, use CLOCKSOURCE_OF_DECLARE and remove the module exit code ? Thanks. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog