From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965987AbbJ3Naa (ORCPT ); Fri, 30 Oct 2015 09:30:30 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:34203 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbbJ3Na2 (ORCPT ); Fri, 30 Oct 2015 09:30:28 -0400 Subject: Re: [PATCH v2] serial: 8250_uniphier: add earlycon support To: Masahiro Yamada References: <1446173176-6966-1-git-send-email-yamada.masahiro@socionext.com> Cc: linux-serial@vger.kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org From: Peter Hurley Message-ID: <563370ED.7040105@hurleysoftware.com> Date: Fri, 30 Oct 2015 09:30:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446173176-6966-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/2015 10:46 PM, Masahiro Yamada wrote: > This reuses the code of drivers/tty/serial/8250/8250_early.c except > > - Overwrite device->port.iotype and device->port.regshift for > UPIO_MEM32 because of_setup_earlycon() has set them for UPIO_MEM. > > - Set device->baud to zero to prevent early8250_setup() from > initializing the divisor register because port->uartclk does not > match the frequency expected by this hardware. Reviewed-by: Peter Hurley