From: Jens Axboe <axboe@kernel.dk>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails
Date: Fri, 30 Oct 2015 17:45:27 -0600 [thread overview]
Message-ID: <56340117.5000103@kernel.dk> (raw)
In-Reply-To: <x49y4ekxtds.fsf@segfault.boston.devel.redhat.com>
On 10/30/2015 09:34 AM, Jeff Moyer wrote:
> From: Vivek Goyal <vgoyal@redhat.com>
>
> If a block device is hot removed and later last reference to device
> is put, we try to writeback the dirty inode. But device is gone and
> that writeback fails.
>
> Currently we do a WARN_ON() which does not seem to be the right thing.
> Convert it to a ratelimited kernel warning.
Any concerns with putting this into 4.4 and marking it for stable? Would
be awesome to have a "Fixes:" in here too.
--
Jens Axboe
next prev parent reply other threads:[~2015-10-30 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 15:34 Jeff Moyer
2015-10-30 23:45 ` Jens Axboe [this message]
2015-11-02 14:58 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56340117.5000103@kernel.dk \
--to=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome