From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752674AbbKBJKn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Nov 2015 04:10:43 -0500
Received: from smtp302.phy.lolipop.jp ([210.157.22.85]:53547 "EHLO
	smtp302.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751310AbbKBJKi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Nov 2015 04:10:38 -0500
Subject: Re: [PATCH] ALSA: firewire-lib: fix compare_const_fl.cocci warnings
To: Julia Lawall <julia.lawall@lip6.fr>
References: <alpine.DEB.2.02.1511020751450.2096@localhost6.localdomain6>
 <56370A2B.6080402@sakamocchi.jp>
 <alpine.DEB.2.02.1511020819390.2096@localhost6.localdomain6>
Cc: kbuild-all@01.org, Takashi Iwai <tiwai@suse.de>,
        Clemens Ladisch <clemens@ladisch.de>, Jaroslav Kysela <perex@perex.cz>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Message-ID: <5637288B.8010007@sakamocchi.jp>
Date: Mon, 2 Nov 2015 18:10:35 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1511020819390.2096@localhost6.localdomain6>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Julia,

On Nov 02 2015 16:20, Julia Lawall wrote:
> On Mon, 2 Nov 2015, Takashi Sakamoto wrote:
>
>> Hi,
>>
>> On Nov 02 2015 15:55, Julia Lawall wrote:
>>> Move constant to the right of binary operators.
>>>
>>> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>>>
>>> CC: Takashi Sakamoto <o-takashi@sakamocchi.jp>
>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>>> ---
>>>
>>> Depends on personal taste, but the modified version does look a little
>>> nicer to me, since one can better see the relationship between the fdf
>>> and sfc fields.
>>>
>>>    amdtp-am824.c |    2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- a/sound/firewire/amdtp-am824.c
>>> +++ b/sound/firewire/amdtp-am824.c
>>> @@ -36,7 +36,7 @@ int amdtp_am824_set_parameters(struct am
>>>    	if (err < 0)
>>>    		return err;
>>>
>>> -	s->fdf = AMDTP_FDF_AM824 | s->sfc;
>>> +	s->fdf = s->sfc | AMDTP_FDF_AM824;
>>>
>>>    	/*
>>>    	 * In IEC 61883-6, one data block represents one event. In ALSA, one
>>
>> Could I request explainations about the advantage of this modification? I
>> cannot imagine good reasons for this subtle changes...
>
> I put the reason under the --- (better see the relationship between fdf
> and sfc).  But if you think the code makes more sense as it is, just
> ignore the patch.

Mmm. I'm sorry but I'm not wiling to add 'Reviewed-by' tag to this patch 
because the reason is non-functional and personal.


Thanks

Takashi Sakamoto