From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754044AbbKCA72 (ORCPT ); Mon, 2 Nov 2015 19:59:28 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51869 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbKCA70 (ORCPT ); Mon, 2 Nov 2015 19:59:26 -0500 X-AuditID: cbfec7f4-f79c56d0000012ee-d7-563806eabaf2 Subject: Re: [PATCH 20/22] clocksource/drivers/exynos_mct: Fix Kconfig and add COMPILE_TEST option To: Daniel Lezcano , tglx@linutronix.de References: <1446469011-22710-1-git-send-email-daniel.lezcano@linaro.org> <1446469011-22710-20-git-send-email-daniel.lezcano@linaro.org> <56380040.3080600@samsung.com> Cc: john.stultz@linaro.org, linux-kernel@vger.kernel.org, arnd@arndb.de, Russell King , Kukjin Kim , "moderated list:ARM SUB-ARCHITECT..." , "moderated list:ARM/SAMSUNG EXYNO..." From: Krzysztof Kozlowski Message-id: <563806E7.6010105@samsung.com> Date: Tue, 03 Nov 2015 09:59:19 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <56380040.3080600@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t/xq7qv2CzCDBb8trD4O+kYu8W8z7IW Z37rWrx+YWjR//g1s8Wmx9dYLS7vmsNmMeP8PiaL25d5LTZvmsrswOXR0tzD5vH71yRGj02r Otk87lzbw+bx7tw5do/NS+o9+rasYvT4vEkugCOKyyYlNSezLLVI3y6BK2PWgd1MBXcEK/a+ X8vUwPiNt4uRk0NCwERi2vK5zBC2mMSFe+vZuhi5OIQEljJKNP84zQrhfGGUeNq1iQ2kSlgg RWLv7h3sILaIgJPEtpv7WEFsIYHVjBKr57GANDALrGGSuLVgAlgRm4CxxOblS8CaeQW0JE7M 7gCzWQRUJZZ8OQrWLCoQITFxQgMrRI2gxI/J91hAbE4BbYkJnx8C2RxAQ/Uk7l/UAgkzC8hL bF7zlnkCo8AsJB2zEKpmIalawMi8ilE0tTS5oDgpPddQrzgxt7g0L10vOT93EyMkLr7sYFx8 zOoQowAHoxIP74Il5mFCrIllxZW5hxglOJiVRHid9gOFeFMSK6tSi/Lji0pzUosPMUpzsCiJ 887d9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwOj6oat/25fXMsLpOnIP3okrxLy2vxp99v9DCdsr a4802sq3NmyttLh4OjdKxrUwboflorSFzye+9976Ra7HY+OEpgrdNU9mb/3k7MjRzHSu6Owb tZIo16Jj9ko9YTrqrmdeFE0LMC38ovZ8RdGyt9c6t68tmLnWPO7zapbX14PWLrH+cYtD6KYS S3FGoqEWc1FxIgB8FWeBhwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.11.2015 09:30, Krzysztof Kozlowski wrote: > On 02.11.2015 21:56, Daniel Lezcano wrote: >> Let the platform's Kconfig to select the clock instead of having a reverse >> dependency from the driver to the platform options. > > Selecting user-visible symbols is rather discouraged so why not > something like this: > > - def_bool y if ARCH_EXYNOS > - depends on !ARM64 > + bool "Exynos multi core timer driver" > + depends on ARCH_EXYNOS || (COMPILE_TEST && ARM) Nope, that was wrong as we loose auto-select on Exynos. Instead: - def_bool y if ARCH_EXYNOS - depends on !ARM64 + bool "Exynos multi core timer driver" if ARM + depends on ARCH_EXYNOS || COMPILE_TEST + default y if ARCH_EXYNOS This way we avoid select (which is a reverse dependency for the driver), have it auto-selectable and compile tested on arm. Best regards, Krzysztof > >> >> Add the COMPILE_TEST option for the compilation test coverage. Due to the >> non portable 'delay' code, this driver is only compilable on ARM. >> >> Signed-off-by: Daniel Lezcano >> --- >> arch/arm/mach-exynos/Kconfig | 1 + >> drivers/clocksource/Kconfig | 4 ++-- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig >> index 3a10f1a..ff10539 100644 >> --- a/arch/arm/mach-exynos/Kconfig >> +++ b/arch/arm/mach-exynos/Kconfig >> @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS >> select SRAM >> select THERMAL >> select MFD_SYSCON >> + select CLKSRC_EXYNOS_MCT >> help >> Support for SAMSUNG EXYNOS SoCs (EXYNOS4/5) >> >> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig >> index 916c36d..d829cbe 100644 >> --- a/drivers/clocksource/Kconfig >> +++ b/drivers/clocksource/Kconfig >> @@ -213,8 +213,8 @@ config CLKSRC_METAG_GENERIC >> This option enables support for the Meta per-thread timers. >> >> config CLKSRC_EXYNOS_MCT >> - def_bool y if ARCH_EXYNOS >> - depends on !ARM64 >> + bool "Exynos multi core timer driver" if COMPILE_TEST >> + depends on ARM >> help >> Support for Multi Core Timer controller on Exynos SoCs. >> >> > >