From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A8C38BF75 for ; Fri, 17 Jul 2026 06:29:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784269777; cv=none; b=mXqsjmiyIxBNrYy2UgN5E5xTS7A63md4ycV9828B4sW1TR5mKjyO9g89Ya6tRzUfFFX0M12W1svItSmbEB1Pq7TAuOTXoRGVYEfHRuvNleQpsF+73nNZT3Dj8HK7iJC/5S8uEitcSAeYCLspEt7jbXil4xXc4cH7Z1R0JqjW1qE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784269777; c=relaxed/simple; bh=Af5lyOwP5GLlNa09upuYHhZ1LfiapkPy2N9xRbcB100=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NKlS7WlpDDlEpP+fLiweOyeoHlXJYnmhbmP8XdpNgadwVZCjUTpoRiGVO7RoiiSDOb55IfrX4ZGN7a5bynZFRnl6ZzRBYaDfRQhG7Fli97gScdCPK/4xhvenG4PbI58WTQyUId8VmXF1tYkq8C2RbwQBTilYt3F+LBwwXdeMzgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jQWnXn/g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jQWnXn/g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D25741F000E9; Fri, 17 Jul 2026 06:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784269774; bh=vt8OGv0LOWuxwEqoxCWnUi3qmJywPj+Zf/7zdmhZMDg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=jQWnXn/gZ9d+ngHHYffqEyswTJpcv3dvrFX+fp69lrDhwhp+vl4Rm25w+/+TUD7LM qX7x07iUjh2KB0LYZovBcztWpt95CWKHfMYyYFMdJnwWl5qRUy5bn08QIXa578jYLF jpB3pz6gDCyFoxFSAgp1jZtdPboppUDsJ5kkJDvnb+iTN/fET8J6apsXHz7Vdip1AX j1rpqTCe+LjZQra16etOQleDdrsuSz3ImmLlqsfjkP2xNG/x/3EBz1uzQt6PLr9MTk 8+CI9R1FYVK29dHyUdqJupzpYNu01PGAGBfU/FJELqLo5Q5MfLcNEdXOf6mcA56gd3 T/nbPqapn4Mqg== Message-ID: <563ae255-a9a6-42f9-8f5f-77b341fed69f@kernel.org> Date: Fri, 17 Jul 2026 09:29:17 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ARM: lpc32xx: only run SoC init on LPC32xx hardware To: Karl Mehltretter , Piotr Wojtaszczyk Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260713192506.7782-1-kmehltretter@gmail.com> From: Vladimir Zapolskiy In-Reply-To: <20260713192506.7782-1-kmehltretter@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/13/26 22:25, Karl Mehltretter wrote: > lpc32xx_check_uid() and lpc32xx_pm_init() are arch_initcalls that poke > LPC32xx-only registers. Since the multiplatform conversion they also > run on other ARCH_MULTI_V5 boards where access faults e.g. on versatile: > > Unable to handle kernel paging request at virtual address f4004130 > PC is at lpc32xx_check_uid+0x2c/0x9c > > Drop the arch_initcall() registrations and call both functions directly > from lpc3250_machine_init(), the machine's .init_machine hook. > The calls are placed in link order (common.c, pm.c, phy3250.c) to > keep their previous relative ordering. > > Fixes: 75bf1bd7d2f9 ("ARM: lpc32xx: allow multiplatform build") > Suggested-by: Arnd Bergmann > Signed-off-by: Karl Mehltretter > --- > v2: > - Rather than guarding the two arch_initcalls, drop the initcalls > entirely and call both functions from lpc3250_machine_init(), which > is already guarded properly. (Suggested by Arnd.) > > arch/arm/mach-lpc32xx/common.c | 5 +---- > arch/arm/mach-lpc32xx/common.h | 2 ++ > arch/arm/mach-lpc32xx/phy3250.c | 2 ++ > arch/arm/mach-lpc32xx/pm.c | 5 +---- > 4 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-lpc32xx/common.c b/arch/arm/mach-lpc32xx/common.c > index 304ea61a0716..35ed3569c5a3 100644 > --- a/arch/arm/mach-lpc32xx/common.c > +++ b/arch/arm/mach-lpc32xx/common.c > @@ -106,7 +106,7 @@ void __init lpc32xx_map_io(void) > iotable_init(lpc32xx_io_desc, ARRAY_SIZE(lpc32xx_io_desc)); > } > > -static int __init lpc32xx_check_uid(void) > +void __init lpc32xx_check_uid(void) > { > u32 uid[4]; > > @@ -119,7 +119,4 @@ static int __init lpc32xx_check_uid(void) > system_serial_low = uid[0]; > system_serial_high = uid[1]; > } > - > - return 1; > } > -arch_initcall(lpc32xx_check_uid); > diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h > index 32f0ad217807..06b20bea324e 100644 > --- a/arch/arm/mach-lpc32xx/common.h > +++ b/arch/arm/mach-lpc32xx/common.h > @@ -16,6 +16,8 @@ > * Other arch specific structures and functions > */ > extern void __init lpc32xx_map_io(void); > +extern void __init lpc32xx_check_uid(void); > +extern void __init lpc32xx_pm_init(void); > extern void __init lpc32xx_serial_init(void); > > /* > diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c > index 66701bf43248..ddc6333ca55d 100644 > --- a/arch/arm/mach-lpc32xx/phy3250.c > +++ b/arch/arm/mach-lpc32xx/phy3250.c > @@ -71,6 +71,8 @@ static const struct of_dev_auxdata lpc32xx_auxdata_lookup[] __initconst = { > > static void __init lpc3250_machine_init(void) > { > + lpc32xx_check_uid(); > + lpc32xx_pm_init(); > lpc32xx_serial_init(); > > of_platform_default_populate(NULL, lpc32xx_auxdata_lookup, NULL); > diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c > index 2572bd89a5e8..9b5c5e1462ed 100644 > --- a/arch/arm/mach-lpc32xx/pm.c > +++ b/arch/arm/mach-lpc32xx/pm.c > @@ -120,7 +120,7 @@ static const struct platform_suspend_ops lpc32xx_pm_ops = { > #define EMC_DYN_MEM_CTRL_OFS 0x20 > #define EMC_SRMMC (1 << 3) > #define EMC_CTRL_REG io_p2v(LPC32XX_EMC_BASE + EMC_DYN_MEM_CTRL_OFS) > -static int __init lpc32xx_pm_init(void) > +void __init lpc32xx_pm_init(void) > { > /* > * Setup SDRAM self-refresh clock to automatically disable o > @@ -129,7 +129,4 @@ static int __init lpc32xx_pm_init(void) > __raw_writel(__raw_readl(EMC_CTRL_REG) | EMC_SRMMC, EMC_CTRL_REG); > > suspend_set_ops(&lpc32xx_pm_ops); > - > - return 0; > } > -arch_initcall(lpc32xx_pm_init); Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir