From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B32288D6 for ; Tue, 25 Nov 2025 04:39:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764045595; cv=none; b=JbThYuTup702fYqEpQAbbZgwonJxJo1RAj1UMwnGDNQjtBCkeL+mA7Giw7ziz15SVz6XoGO8LbGKM6ftab725moOnHo7pv+jw8VWlJ/5AvMKurZdcB2L+vav5pQ+Ah7oNbs2BbLbsw5jO4OnX04w4pfGm8YVvrTpQ95ZVKljQJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764045595; c=relaxed/simple; bh=PqhXoX6syIlr7YWSSRKqka0qQvPciO+riWeEDaFK1Jk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MWGGPXnhYjKUKvKtigrjSMnqVtbSN6ujkCDqkKwqNJ7kh+bELCkT98/Sf4pd59qovgt4bgPGl8gLXkKVZIsvHQupLnMXz8m5aZJUAz8G5n3rtICaZYfpYeJr0VQMfvC+hQoQTr3+dSln76kHNeEMRLB0QZO2zfOpXqT/M1L/HtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UYY97Ywd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZyW1uLz+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UYY97Ywd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZyW1uLz+" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AP2gcAr1383979 for ; Tue, 25 Nov 2025 04:39:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WKGJQRmKN668jJatHPk6H0FjYzmlIbNO0WQvdoTrBI0=; b=UYY97Ywd6nInmUh+ Ae7VAqZjm7cH3iRelQK59JIKMEHz9vuWtLRz/Z2dKseSxz5ijYXJbOmxM/OHU4EB PBZAOCrWjC8Ex0qxSOp2to0WXoDlmyrDJ0xyt99Auzn9TqpxYx4ir97BmQ8BCofz GRWzfE2/m6K3MA7c+jdfzKN1ZicVxr8e00NYByWaIwBJsrWMf3QcKKMIv7jQ84hv ZY5Z9dbORWKVsYPY4dR8wqBodnW7F7U57wJaxm1bkCNFJByNzt+yHORgZLvj+Pus xtpnWdlm3O31+jYFSZe+JQ3yuptr7o+YsUnyyZPTFvASQp/++oGYh3ubCZmdZE08 GiWPqg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amk10kbxk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Nov 2025 04:39:53 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297f48e81b8so71964795ad.0 for ; Mon, 24 Nov 2025 20:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764045593; x=1764650393; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WKGJQRmKN668jJatHPk6H0FjYzmlIbNO0WQvdoTrBI0=; b=ZyW1uLz+TNYpXfS9nljYLDQy6Aj98sXpp0mDkjpPPc9De0Asa38eWj5IJG+5prqf7W /u0D2nRNr5LxvF4p072njzfAqcPHxzLqbqxAvQO7Q1LA6NAkr9lIV/0AkWzdVuMhIxZG +y9R6H9RZX8c7IEOPanv52WyJGHeGoeJOTXPQBOH4boLP6VHIHSr/87oo7EOH6bzA8kK bJ79TAOkCh/HFKDAmIgs1ZSnSv/j2ZFZO6pKPg6jKOZWqE80fIFlscjXf9JvTTWYjY6c JYBOxcG3XOCXG5nQuY2iZApx2XrKOgdI5XH4pX+VbpJEnBCzw8ky0o4IKH1hlhDfL9q6 +htQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764045593; x=1764650393; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WKGJQRmKN668jJatHPk6H0FjYzmlIbNO0WQvdoTrBI0=; b=dV/2fEPLylOg+Zym7dATp5clfXQ2S8/aC2vm0PyP2qnDQCoOGIB9fvY/lKMFnbqueJ MPF4opLN3AInb71yg48kYkosskCmurUZnDrhkNhb9AJCs36EqfL/mN/aQW4OMJ0HJVVy /B+opKqILd9Zh4mFN7n0w9OJeypQQN3LqArX6JUi28HTxq4A88M8j0jLGh0DCJdsDwsx eBiLd3zE38AGef4rD4kwY9BbrckwboyyD/pUQOk7QRkzGAilWY7Qau3L9eDdojlTT+FL zCv971DQoBrBhz/H2echHsYyqqccyUHI0ruVQeEpvaAoP7ZF6pLlMeuH5GklpauVAiHy tShA== X-Forwarded-Encrypted: i=1; AJvYcCWFMRM3xZZ0E0NVwmnWdR1O33/7rNA8Y2UnomqYNGNGj0Q2PGTdJQRb/rrcKJoftII3Dm0QckQIT6ai2aw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw01Dw/BuirdiHzzA/qvbULYbvNk+ZWAYCsFwobdgJbf0kQZwv9 Tr+SmZ84+a/lFM2rDld9CpYHYIqzSMNcGttw8CVS6u2QKd2uD6N9ob1fAENawGxdOSpVuegsIYm xuzGI1YtqCoSGUc98gRc279tYiIboCSjJS7EPn9K8FjltZDikveEcfK+Oz5B4dC1aQYI= X-Gm-Gg: ASbGncsZsMD1zkpDq+cbAa2uo/1BvhItIkx6vcMnWz//h9DMsYlVE1VxTHUtY+4w5gh 8V1CDCjhYvJaZQAw7XUSJr2mzrmnj1i9bEk5VpQY/IMSrrVi16uqwN+0ZmjdA/k5+eUlzl2l+oP v2A2fflthw0gcXcYt2kjhLJHU+19tCJzoQoP11Tq61f56z0z4rCSZ1/b8ZYaJHfBP5RahfQsqlG 3DEjkhl6GV1nrYezhEnmM310beoj2c/a1vzgezCk8QsMmcTkFOFqPvpbCfM94b1zpNC8b2vJupa 6aNFouQrHFlh5TXGET/OkLCHKe1dbcUN1X3jcFqB9ftgeXoE8eITKw3pxq7eyjQ5bqynMzjy0ti fRhv3HdTM+AlWkxrClN/Mtarn4oIoFDXI9sSPISVGuA== X-Received: by 2002:a17:903:3c67:b0:29a:69d:acdc with SMTP id d9443c01a7336-29b6bffd87amr128408325ad.25.1764045592781; Mon, 24 Nov 2025 20:39:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrUh65gzF34YTtoe7WZeNXxWSJVbbsWN2fH6U/+v9lEO6lwtOlTOXkPO/OwueK9HnEl8fClw== X-Received: by 2002:a17:903:3c67:b0:29a:69d:acdc with SMTP id d9443c01a7336-29b6bffd87amr128407905ad.25.1764045592070; Mon, 24 Nov 2025 20:39:52 -0800 (PST) Received: from [10.0.0.3] ([106.222.230.111]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b1077e9sm154734895ad.15.2025.11.24.20.39.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 20:39:51 -0800 (PST) Message-ID: <563d673a-19e8-f161-ab2f-6e8acd420531@oss.qualcomm.com> Date: Tue, 25 Nov 2025 10:09:46 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] media: venus: vdec: restrict EOS addr quirk to IRIS2 only To: Konrad Dybcio , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab , Viswanath Boma , Stanimir Varbanov Cc: Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Renjiang Han , Mecid Urganci References: <20251124-venus-vp9-fix-v1-1-2ff36d9f2374@oss.qualcomm.com> <2622656e-9abd-4407-b1fa-228da9959d60@oss.qualcomm.com> Content-Language: en-US From: Dikshita Agarwal In-Reply-To: <2622656e-9abd-4407-b1fa-228da9959d60@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kq0BYDIR8W7U7OZIIBMWguJX4Sq3wAZw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI1MDAzNSBTYWx0ZWRfX+snFSqKnzMX+ y0WGedWkDDalCL2KSFVCn0hO0OOQ73BW3wxOo8dfBeDzwPrObgB4CshV4TLqlPRKbdPj1Rdk70g eLAB2SkRCGB87oOuw6YhKZq2DfphNNbIHc5HA/DpEIgo2xhAZNz5/XZlq7TVuHjG0m5O3Lf1aQ8 bQMVjDBW3u+u3OM75LQ5hrDAsqNDNJamcMJZF42qpvoRRHWsHC82XTJ8AIUtrtZJkQxYq7G8VDy trisga3gzXe5te4KG8Ow3z2GtbDO2HBR8OCWGo4inVMB1PFZ6JtWLT/n/ydDIDYZSB/K62CKhGc QaYBvImhyw/iPEStU2WgeyBDhCAela5ie+WyaZP83ghPUzqARe8qR9VCxYp2TX+ODpBsZjvcobZ Yx8+YiKFOstacvP1TZGTy14EMNyw9g== X-Proofpoint-ORIG-GUID: kq0BYDIR8W7U7OZIIBMWguJX4Sq3wAZw X-Authority-Analysis: v=2.4 cv=SP9PlevH c=1 sm=1 tr=0 ts=69253319 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=12FOtvgV4D2gsqRYbU+y8g==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=NEAV23lmAAAA:8 a=9Av3R2nQW4dSFDgMc8UA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_01,2025-11-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511250035 On 11/24/2025 4:36 PM, Konrad Dybcio wrote: > On 11/24/25 11:58 AM, Dikshita Agarwal wrote: >> On SM8250 (IRIS2) with firmware older than 1.0.087, the firmware could >> not handle a dummy device address for EOS buffers, so a NULL device >> address is sent instead. The existing check used IS_V6() alongside a >> firmware version gate: >> >> if (IS_V6(core) && is_fw_rev_or_older(core, 1, 0, 87)) >> fdata.device_addr = 0; >> else >> fdata.device_addr = 0xdeadb000; >> >> However, SC7280 which is also V6, uses a firmware string of the form >> "1.0.", which the version parser translates to 1.0.0. This >> unintentionally satisfies the `is_fw_rev_or_older(..., 1, 0, 87)` >> condition on SC7280. Combined with IS_V6() matching there as well, the >> quirk is incorrectly applied to SC7280, causing VP9 decode failures. >> >> Constrain the check to IRIS2 (SM8250) only, which is the only platform >> that needed this quirk, by replacing IS_V6() with IS_IRIS2(). This >> restores correct behavior on SC7280 (no forced NULL EOS buffer address). > > This really needs an inline comment, since you provided a long backstory > explaining how fragile this check is Sure, will add. > >> Fixes: 47f867cb1b63 ("media: venus: fix EOS handling in decoder stop command") >> Cc: stable@vger.kernel.org >> Reported-by: Mecid > > This is certainly not a correct email to use... it will at best bounce > or get ignored and at worst cause some unintended interactions with gh if > you have an account registered with the email you're sending from > > I opened that person's GH profile and grabbed the git identify of a recent > commit made attributed to this account: > > Mecid Urganci Thanks for this, I tried but couldn't find the proper id, will fix in v2. Regards, Dikshita > > (+CC Mecid, -CC github, fwiw) > > Konrad