From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbbKINtw (ORCPT ); Mon, 9 Nov 2015 08:49:52 -0500 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:53621 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbbKINtu (ORCPT ); Mon, 9 Nov 2015 08:49:50 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Message-ID: <5640A47B.8050402@mev.co.uk> Date: Mon, 09 Nov 2015 13:49:47 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Geliang Tang , H Hartley Sweeten , Greg Kroah-Hartman CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] staging: comedi: use kmalloc_array instead of kmalloc References: <6ada2cca5a646c6bea9a900a48109d10cdc45e85.1446991712.git.geliangtang@163.com> In-Reply-To: <6ada2cca5a646c6bea9a900a48109d10cdc45e85.1446991712.git.geliangtang@163.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/11/15 14:17, Geliang Tang wrote: > Use kmalloc_array instead of kmalloc to allocate memory for an array. > > Signed-off-by: Geliang Tang > --- > drivers/staging/comedi/drivers/amplc_pci224.c | 8 ++++---- > drivers/staging/comedi/drivers/ni_670x.c | 5 +++-- > 2 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c b/drivers/staging/comedi/drivers/amplc_pci224.c > index b2f7679..d39f02d 100644 > --- a/drivers/staging/comedi/drivers/amplc_pci224.c > +++ b/drivers/staging/comedi/drivers/amplc_pci224.c > @@ -1022,14 +1022,14 @@ pci224_auto_attach(struct comedi_device *dev, unsigned long context_model) > irq = pci_dev->irq; > > /* Allocate buffer to hold values for AO channel scan. */ > - devpriv->ao_scan_vals = kmalloc(sizeof(devpriv->ao_scan_vals[0]) * > - board->ao_chans, GFP_KERNEL); > + devpriv->ao_scan_vals = kmalloc_array(board->ao_chans, > + sizeof(devpriv->ao_scan_vals[0]), GFP_KERNEL); > if (!devpriv->ao_scan_vals) > return -ENOMEM; > > /* Allocate buffer to hold AO channel scan order. */ > - devpriv->ao_scan_order = kmalloc(sizeof(devpriv->ao_scan_order[0]) * > - board->ao_chans, GFP_KERNEL); > + devpriv->ao_scan_order = kmalloc_array(board->ao_chans, > + sizeof(devpriv->ao_scan_order[0]), GFP_KERNEL); > if (!devpriv->ao_scan_order) > return -ENOMEM; > It would be better if the patch preserved the existing whitespace style here, even though that increases the number of lines. > diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c > index f4c580f..3e7271880 100644 > --- a/drivers/staging/comedi/drivers/ni_670x.c > +++ b/drivers/staging/comedi/drivers/ni_670x.c > @@ -214,8 +214,9 @@ static int ni_670x_auto_attach(struct comedi_device *dev, > if (s->n_chan == 32) { > const struct comedi_lrange **range_table_list; > > - range_table_list = kmalloc(sizeof(struct comedi_lrange *) * 32, > - GFP_KERNEL); > + range_table_list = kmalloc_array(32, > + sizeof(struct comedi_lrange *), > + GFP_KERNEL); > if (!range_table_list) > return -ENOMEM; > s->range_table_list = range_table_list; > -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-