mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ian McDonald" <ian.mcdonald@jandi.co.nz>
To: prasanna@in.ibm.com
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Andi Kleen" <ak@suse.de>, "Jim Keniston" <jkenisto@us.ibm.com>,
	"Chuck Ebbert" <cebbert@redhat.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	ananth@in.ibm.com, anil.s.keshavamurthy@intel.com,
	"David S. Miller" <davem@davemloft.net>,
	"Patrick Andrieux" <patrick.andrieux@gmail.com>,
	"DCCP Mailing List" <dccp@vger.kernel.org>,
	jbeulich@novell.com, systemtap@sources.redhat.com
Subject: Re: [PATCH] Kprobes i386 fix for mark ro data
Date: Sun, 10 Jun 2007 18:24:15 +1200	[thread overview]
Message-ID: <5640c7e00706092324kd0ea8e0pef4a4cd764fce5d3@mail.gmail.com> (raw)
In-Reply-To: <20070607042229.GA9350@in.ibm.com>

On 6/7/07, S. P. Prasanna <prasanna@in.ibm.com> wrote:
> > >It faulted when it tried to write the breakpoint instruction into the
> > >running kernel's executable code. Apparently the kernel code is now marked
> > >read-only?
> > >
> > >
> > Yes it would appear to be the case as user has CONFIG_DEBUG_RODATA
> > set. Patrick - can you turn this off and retest? It's under Kernel
> > Hacking, Write protect kernel read only data structures.
> >
>
> Ian,
>
> Please find the fix as suggested by Andi Kleen
> for the above stated problem.
>
> Thanks
> Prasanna
>
>
I went to test the fix and first of all went to replicate the problem.
My build has CONFIG_DEBUG_RODATA set but the problem does not occur
without the patch. Should I be concerned about this and raise a bug
for that as I would think that means there is a problem that the read
only protection isn't working (this is off Linus' tree synced
tonight).

Patrick - can you test whether this patch fixes your problem? You said
disabling CONFIG_DEBUG_RODATA fixed your problem but can you try
re-enabling and testing this patch?

Ian
-- 
Web: http://wand.net.nz/~iam4/
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group

  parent reply	other threads:[~2007-06-10  6:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-06 20:47 [BUG] Fwd: segfault : modprobe dccp_probe/tcp_probe Ian McDonald
2007-06-06 22:55 ` Chuck Ebbert
2007-06-06 23:12   ` Ian McDonald
2007-06-07  4:22     ` [PATCH] Kprobes i386 fix for mark ro data S. P. Prasanna
2007-06-07  4:24       ` [PATCH] Kprobes x86_64 " S. P. Prasanna
2007-06-10  6:24       ` Ian McDonald [this message]
2007-06-11 18:36         ` [PATCH] Kprobes i386 " Patrick Andrieux
2007-06-07 10:24     ` [BUG] Fwd: segfault : modprobe dccp_probe/tcp_probe Patrick Andrieux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5640c7e00706092324kd0ea8e0pef4a4cd764fce5d3@mail.gmail.com \
    --to=ian.mcdonald@jandi.co.nz \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=cebbert@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dccp@vger.kernel.org \
    --cc=jbeulich@novell.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick.andrieux@gmail.com \
    --cc=prasanna@in.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®