From: "Ian McDonald" <ian.mcdonald@jandi.co.nz>
To: "Jesper Juhl" <jesper.juhl@gmail.com>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Andrea Bittau" <a.bittau@cs.ucl.ac.uk>,
"Arnaldo Carvalho de Melo" <acme@ghostprotocols.net>,
dccp@vger.kernel.org
Subject: Re: [PATCH][dccp] Fix memory leak and clean up style - dccp_feat_empty_confirm()
Date: Fri, 27 Jul 2007 11:16:28 +1200 [thread overview]
Message-ID: <5640c7e00707261616x8eb332fg2406b72d2e1f1f12@mail.gmail.com> (raw)
In-Reply-To: <200707270039.37860.jesper.juhl@gmail.com>
On 7/27/07, Jesper Juhl <jesper.juhl@gmail.com> wrote:
>
> Greetings,
>
> There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm().
> If we hit the 'default:' case of the 'switch' statement, then we
> return without freeing 'opt', thus leaking 'struct dccp_opt_pend'
> bytes.
> The leak is fixed easily enough by adding a kfree(opt); before the
> return statement.
> The patch also changes the layout of the 'switch' to be more in line
> with CodingStyle.
>
> Patch has been compile tested.
>
> Please consider merging.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
--
Web1: http://wand.net.nz/~iam4/
Web2: http://www.jandi.co.nz
Blog: http://iansblog.jandi.co.nz
prev parent reply other threads:[~2007-07-26 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 22:39 Jesper Juhl
2007-07-26 23:16 ` Ian McDonald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5640c7e00707261616x8eb332fg2406b72d2e1f1f12@mail.gmail.com \
--to=ian.mcdonald@jandi.co.nz \
--cc=a.bittau@cs.ucl.ac.uk \
--cc=acme@ghostprotocols.net \
--cc=dccp@vger.kernel.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®