From: Dave Hansen <dave.hansen@intel.com>
To: Huaitong Han <huaitong.han@intel.com>,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/fpu: Fix get_xsave_addr which returns error pointer to KVM
Date: Tue, 10 Nov 2015 14:40:16 -0800 [thread overview]
Message-ID: <56427250.1020407@intel.com> (raw)
In-Reply-To: <1446800423-21622-1-git-send-email-huaitong.han@intel.com>
On 11/06/2015 01:00 AM, Huaitong Han wrote:
> when KVM uses the get_xsave_addr, xsave parameter belongs to guest vcpu, if
> xsave is replaced with current task (host) xsave, get_xsave_addr will return error
> xsave addr to KVM.
>
> Signed-off-by: Huaitong Han <huaitong.han@intel.com>
Looks good to me. It was completely bogus that we passed 'xsave' in
there and then just wrote over it.
Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
next prev parent reply other threads:[~2015-11-10 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 9:00 Huaitong Han
2015-11-10 22:40 ` Dave Hansen [this message]
2015-11-12 13:28 ` [tip:x86/urgent] x86/fpu: Fix get_xsave_addr() behavior under virtualization tip-bot for Huaitong Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56427250.1020407@intel.com \
--to=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=huaitong.han@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome