From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752340AbbKKOLy (ORCPT ); Wed, 11 Nov 2015 09:11:54 -0500 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:57364 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbbKKOLx (ORCPT ); Wed, 11 Nov 2015 09:11:53 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro To: Ranjith T , gregkh@linuxfoundation.org References: <1447091324-16310-1-git-send-email-ranjithece24@gmail.com> Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <56434CA6.3000007@mev.co.uk> Date: Wed, 11 Nov 2015 14:11:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/2015 13:44, Ranjith T wrote: > Is this patch is fine?. > > Thanks, > Ranjith T. Fine apart from the "Signed-off-by" line. I'm guessing your last name isn't really "T". > On Mon, Nov 9, 2015 at 11:18 PM, Ranjith T wrote: >> BIT macro is used for defining BIT location instead of >> shifting operator - coding style issue >> >> Signed-off-by: Ranjith T >> --- >> drivers/staging/comedi/drivers/comedi_parport.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c >> index 15a4093..1bf8ddc 100644 >> --- a/drivers/staging/comedi/drivers/comedi_parport.c >> +++ b/drivers/staging/comedi/drivers/comedi_parport.c >> @@ -75,8 +75,8 @@ >> #define PARPORT_DATA_REG 0x00 >> #define PARPORT_STATUS_REG 0x01 >> #define PARPORT_CTRL_REG 0x02 >> -#define PARPORT_CTRL_IRQ_ENA (1 << 4) >> -#define PARPORT_CTRL_BIDIR_ENA (1 << 5) >> +#define PARPORT_CTRL_IRQ_ENA BIT(4) >> +#define PARPORT_CTRL_BIDIR_ENA BIT(5) >> >> static int parport_data_reg_insn_bits(struct comedi_device *dev, >> struct comedi_subdevice *s, >> -- >> 1.7.10.4 -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-