From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Dave Penkler <dpenkler@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
peter.chen@freescale.com, teuniz@gmail.com,
USB <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dpenkler@gmail.org
Subject: Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.
Date: Wed, 11 Nov 2015 22:48:03 +0300 [thread overview]
Message-ID: <56439B73.8070909@cogentembedded.com> (raw)
In-Reply-To: <CAHp75Vfip8uo5iWvi-wdLkvmBGHeZwn-cUWPzWOuDZjf+5J3gw@mail.gmail.com>
Hello.
On 11/11/2015 10:03 PM, Andy Shevchenko wrote:
>> Background:
>> When performing a read on an instrument that is executing a function
>> that runs longer than the USB timeout the instrument may hang and require
>> a device reset to recover. The READ_STATUS_BYTE operation always returns
>> even when the instrument is busy permitting to poll for the appropriate
>> condition. This capability is refered to in instrument application notes
Referred.
>> on synchronizing acquisitions for other platforms.
>
> Won't comment precisely by line, but common nitpicks about style:
> - added empty lines where no need
> - redundant parens
> - pieces of code takes whole line when they are quite fit tail of previous one.
>
> And why malloc for 8 bytes?
To be able to do DMA with this buffer, apparently.
>> Signed-off-by: Dave Penkler <dpenkler@gmail.com>
[patch skipped]
It's a good tone to skip the parts you're not commenting on, so others
wouldn't have to scroll in vain.
WBR, Sergei
next prev parent reply other threads:[~2015-11-11 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 11:08 [PATCH v3 0/5] usb: usbtmc: Add support for missing functions in USBTMC-USB488 spec Dave Penkler
2015-11-11 11:16 ` [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation Dave Penkler
2015-11-11 19:03 ` Andy Shevchenko
2015-11-11 19:48 ` Sergei Shtylyov [this message]
2015-11-11 19:54 ` Andy Shevchenko
2015-11-11 21:08 ` Greg Kroah-Hartman
[not found] ` <CAL=kjP3sdPu4FZcznoGMo5a_S2fi376UdfykcMw65+w2g+QQqA@mail.gmail.com>
2015-11-12 9:41 ` Andy Shevchenko
2015-11-11 11:16 ` [PATCH v3 2/5] Add support for USBTMC USB488 SRQ notification with fasync Dave Penkler
2015-11-11 11:16 ` [PATCH v3 3/5] Add support for receiving USBTMC USB488 SRQ notifications via poll/select Dave Penkler
2015-11-11 19:04 ` Andy Shevchenko
2015-11-11 11:20 ` [PATCH v3 4/5] Add ioctl to retrieve USBTMC-USB488 capabilities Dave Penkler
2015-11-11 19:34 ` Andy Shevchenko
2015-11-11 11:21 ` [PATCH v3 5/5] Add ioctls to enable and disable local controls on an instrument Dave Penkler
2015-11-11 19:36 ` Andy Shevchenko
2015-11-13 8:59 ` Dave Penkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56439B73.8070909@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andy.shevchenko@gmail.com \
--cc=dpenkler@gmail.com \
--cc=dpenkler@gmail.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@freescale.com \
--cc=teuniz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome