From: "Matias Bjørling" <m@bjorling.me>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-block@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] lightnvm: change max_phys_sect to ushort
Date: Thu, 12 Nov 2015 19:57:14 +0100 [thread overview]
Message-ID: <5644E10A.9010703@bjorling.me> (raw)
In-Reply-To: <CAMuHMdXcF71dGqCSqTCDQgd_7+e+mEg0Qu=50pzzrP3mVY94tA@mail.gmail.com>
On 11/12/2015 07:42 PM, Geert Uytterhoeven wrote:
> On Thu, Nov 12, 2015 at 7:35 PM, Matias Bjørling <m@bjorling.me> wrote:
>> The max_phys_sect variable is defined as a char. We do a boundary check
>> to maximally allow 256 physical page descriptors per command. As we are
>> not indexing from zero. This expression is always in false. Bump the
>> max_phys_sect to an unsigned short to support the range check.
>
> unsigned int?
Grah, I need to be more careful. I sent the wrong patch after I had
fixed it to unsigned short.
next prev parent reply other threads:[~2015-11-12 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 18:35 Matias Bjørling
2015-11-12 18:42 ` Geert Uytterhoeven
2015-11-12 18:57 ` Matias Bjørling [this message]
2015-11-12 19:02 ` Linus Torvalds
2015-11-12 19:05 ` Matias Bjørling
2015-11-16 11:18 ` Thiago Farina
2015-11-16 11:21 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5644E10A.9010703@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=geert@linux-m68k.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome