mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: chenguohua@jari.cn
To: hare@suse.com, jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [SCSI] aic7xxx: Clean up errors in aiclib.h
Date: Wed, 27 Sep 2023 15:02:35 +0800 (GMT+08:00)	[thread overview]
Message-ID: <5645eb7.87d.18ad5725a91.Coremail.chenguohua@jari.cn> (raw)

Fix the following errors reported by checkpatch:

ERROR: open brace '{' following struct go on the same line
ERROR: return is not a function, parentheses are not required
ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>
---
 drivers/scsi/aic7xxx/aiclib.h | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/aic7xxx/aiclib.h b/drivers/scsi/aic7xxx/aiclib.h
index ba08eb3c4e3b..a7d0a2d912cd 100644
--- a/drivers/scsi/aic7xxx/aiclib.h
+++ b/drivers/scsi/aic7xxx/aiclib.h
@@ -57,8 +57,7 @@
 #ifndef	_AICLIB_H
 #define _AICLIB_H
 
-struct scsi_sense
-{
+struct scsi_sense {
 	uint8_t opcode;
 	uint8_t byte2;
 	uint8_t unused[2];
@@ -72,8 +71,7 @@ struct scsi_sense
 #define		SCSI_REV_SPC		3
 #define		SCSI_REV_SPC2		4
 
-struct scsi_sense_data
-{
+struct scsi_sense_data {
 	uint8_t error_code;
 #define	SSD_ERRCODE			0x7F
 #define		SSD_CURRENT_ERROR	0x70
@@ -135,7 +133,7 @@ scsi_4btoul(uint8_t *bytes)
 	     (bytes[1] << 16) |
 	     (bytes[2] << 8) |
 	     bytes[3];
-	return (rv);
+	return rv;
 }
 
 /* Macros for generating the elements of the PCI ID tables. */
@@ -144,7 +142,7 @@ scsi_4btoul(uint8_t *bytes)
 
 #define ID_C(x, c)						\
 {								\
-	GETID(x,32), GETID(x,48), GETID(x,0), GETID(x,16),	\
+	GETID(x, 32), GETID(x, 48), GETID(x, 0), GETID(x, 16),	\
 	(c) << 8, 0xFFFF00, 0					\
 }
 
-- 
2.17.1

                 reply	other threads:[~2023-09-27  7:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5645eb7.87d.18ad5725a91.Coremail.chenguohua@jari.cn \
    --to=chenguohua@jari.cn \
    --cc=hare@suse.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®