From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933370AbbKMRI2 (ORCPT ); Fri, 13 Nov 2015 12:08:28 -0500 Received: from lists.s-osg.org ([54.187.51.154]:54561 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932993AbbKMRI1 (ORCPT ); Fri, 13 Nov 2015 12:08:27 -0500 Subject: Re: [PATCH] HSI: Remove struct hsi_client private fields from kernel-doc To: linux-kernel@vger.kernel.org References: <1444288308-11469-1-git-send-email-javier@osg.samsung.com> Cc: Sebastian Reichel From: Javier Martinez Canillas Message-ID: <56461906.2000107@osg.samsung.com> Date: Fri, 13 Nov 2015 14:08:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444288308-11469-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sebastian, On 10/08/2015 04:11 AM, Javier Martinez Canillas wrote: > The kernel-doc how to says that structure fields that are inside a > "private:" area shouldn't be listed in the generated documentation > but the private fields for struct hsi_client private are listed. > > This also fixes the following make htmldocs warnings: > > .//include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typedef member 'e_handler' description in 'hsi_client' > .//include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typedef member 'pclaimed' description in 'hsi_client' > .//include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typedef member 'nb' description in 'hsi_client' > > Signed-off-by: Javier Martinez Canillas > > --- > > include/linux/hsi/hsi.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/hsi/hsi.h b/include/linux/hsi/hsi.h > index 5dd60c2e120f..2790591c77cf 100644 > --- a/include/linux/hsi/hsi.h > +++ b/include/linux/hsi/hsi.h > @@ -135,9 +135,6 @@ static inline int hsi_register_board_info(struct hsi_board_info const *info, > * @device: Driver model representation of the device > * @tx_cfg: HSI TX configuration > * @rx_cfg: HSI RX configuration > - * @e_handler: Callback for handling port events (RX Wake High/Low) > - * @pclaimed: Keeps tracks if the clients claimed its associated HSI port > - * @nb: Notifier block for port events > */ > struct hsi_client { > struct device device; > Any comments about this patch? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America