mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
To: Pali Rohar <pali.rohar@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Compile errors with dell_rbtn_notifier_register
Date: Thu, 21 May 2015 16:53:37 -0400	[thread overview]
Message-ID: <56482.1432241617@turing-police.cc.vt.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

commit 61104aa44529d59bd01a5d51df571ca2823a04b3
Author: Pali Rohár <pali.rohar@gmail.com>
Date:   Thu May 14 12:54:27 2015 +0200

    dell-laptop: Use dell-rbtn instead i8042 filter when possible

causes build errors:

  LD      init/built-in.o       
drivers/built-in.o: In function `dell_init':
/usr/src/linux-next/drivers/platform/x86/dell-laptop.c:762: undefined reference to `dell_rbtn_notifier_register'
/usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2016: undefined reference to `dell_rbtn_notifier_unregister'
drivers/built-in.o: In function `dell_exit':
/usr/src/linux-next/drivers/platform/x86/dell-laptop.c:2041: undefined reference to `dell_rbtn_notifier_unregister'

when built with:

CONFIG_DELL_LAPTOP=y
CONFIG_DELL_RBTN=m

because the builtin then references a symbol that's in a module.

Probably needs some Kconfig magic to ensure this case doesn't happen.

[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

             reply	other threads:[~2015-05-21 20:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 20:53 Valdis Kletnieks [this message]
2015-05-21 20:59 ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56482.1432241617@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®