From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbbKRCN2 (ORCPT ); Tue, 17 Nov 2015 21:13:28 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:41722 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbbKRCN0 (ORCPT ); Tue, 17 Nov 2015 21:13:26 -0500 X-AuditID: cbfec7f5-f794b6d000001495-96-564bdec31c73 Subject: Re: [PATCHv2 3/3] ASoC: samsung: pass filter function as pointer To: Arnd Bergmann , Mark Brown References: <6346833.MfUC71I3uD@wuerfel> <6346833.dgFksO4fT8@wuerfel> Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org, Heiko Stuebner , Sangbeom Kim , Liam Girdwood , linux-kernel@vger.kernel.org, Vinod Koul , Kukjin Kim , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <564BDEBE.2080706@samsung.com> Date: Wed, 18 Nov 2015 11:13:18 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <6346833.dgFksO4fT8@wuerfel> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsVy+t/xq7qH73mHGWxdwmZx5eIhJou/k46x W0x9+ITN4v+j16wWr18YWvQ/fs1s8e1KB5PFpsfXWC0u75rDZjHj/D4mi4srvjBZvOzbz+LA 47HhcxObx+9fkxg9ds66y+6xeM9LJo9NqzrZPDYvqffo27KK0WP7tXnMHp83yQVwRnHZpKTm ZJalFunbJXBlPNt6grHgLXfF1mcfmBoYV3N2MXJySAiYSHxYsZ0JwhaTuHBvPVsXIxeHkMBS RomXi1qYIJwvjBLrJ1xlB6kSFvCUaJ06HcwWEXCSuHT0KksXIwdQkavEx9scIPXMAruZJH5v msQKUsMmYCyxefkSNogNchK93ZNYQGxeAS2JHadWg9ksAqoSl2ZvA6sRFYiQmDihgRWiRlDi x+R7YDWcApoSR/ZdYgLZxSygJ3H/ohZImFlAXmLzmrfMExgFZyHpmIVQNQtJ1QJG5lWMoqml yQXFSem5RnrFibnFpXnpesn5uZsYIRH1dQfj0mNWhxgFOBiVeHgTF3uHCbEmlhVX5h5ilOBg VhLhvXoYKMSbklhZlVqUH19UmpNafIhRmoNFSZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQbG 1O/NVVO+OYW7tc+qLDHh3av9V7O500zd4M++jG9x3ecjGeSmxdYpJBx2q6p8n8pxxfn4XPtA Lw7Rzrx7Gdu/7lvKs7/0ZZF3iY3GN73TG1ZvNgrcyT61Y80ONSfJmz3HziUzcHupFmyedL5t wuPAvVLTCldHF9pHZq1fIVR/Y55tSvykuDwlluKMREMt5qLiRADL0FCwpAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.11.2015 00:55, Arnd Bergmann wrote: > As we are now passing the filter data as pointers to the drivers, > we can take the final step and also pass the filter function the > same way. I'm keeping this change separate, as there it's less > obvious that this is a net win. > > Upsides of this are: > > - The ASoC drivers are completely independent from the DMA engine > implementation, which simplifies the Kconfig logic and in theory > allows the same sound drivers to be built in a kernel that supports > different kinds of dmaengine drivers. > > - Consistency with other subsystems and drivers > > On the other hand, we have a few downsides: > > - The s3c24xx-dma driver now needs to be built-in for the ac97 platform > device to be instantiated on s3c2440. > > - samsung_dmaengine_pcm_config cannot be marked 'const' any more > because the filter function pointer needs to be set at runtime. > This is safe as long we don't have multiple different DMA engines > in thet same system at runtime, but is nonetheless ugly. > > Signed-off-by: Arnd Bergmann > --- > v2: avoid possibly NULL pdata > Looks good. I also tested entire patchset on Exynos4412/Trats2 board (custom kernel with audio working) for regressions and it worked fine. However, since this was not a S3C24xx/S3C64xx board, I don't find that testing sufficient for a tag. So only: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof