From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933561AbbKRQfD (ORCPT ); Wed, 18 Nov 2015 11:35:03 -0500 Received: from smtp65.iad3a.emailsrvr.com ([173.203.187.65]:51522 "EHLO smtp65.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933203AbbKRQe7 (ORCPT ); Wed, 18 Nov 2015 11:34:59 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro To: Ranjith Thangavel , gregkh@linuxfoundation.org References: <1447521036-23550-1-git-send-email-ranjithece24@gmail.com> <564CA6CC.6010600@mev.co.uk> Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <564CA8B1.8080404@mev.co.uk> Date: Wed, 18 Nov 2015 16:34:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <564CA6CC.6010600@mev.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/15 16:26, Ian Abbott wrote: > On 14/11/15 17:10, Ranjith Thangavel wrote: >> BIT macro is used for defining BIT location instead of >> shifting operator, usleep_range is preferred over >> udelay - coding style issue > > Those two things should be done in separate patches. Sorry, I didn't see you've reposted this as two separate patches, so ignore my previous reply. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-